#359 Drop rpm-py-installer from requires
Merged 5 years ago by cqi. Opened 5 years ago by cqi.

file modified
+43
@@ -14,6 +14,49 @@ 

  There are parts of koji code in pyrpkg/cli, those parts are licensed

  under LGPLv2(.1).  See COPYING-koji for that license statement.

  

+ Installation

+ ============

+ 

+ Install from distribution packages

+ ----------------------------------

+ 

+ rpkg is available in Fedora and EPEL repositories. It can be installed with

+ package manager command. There are Python 2 and 3 package for Fedora and only

+ Python 2 package in EPEL.

+ 

+ Install in a Fedora system::

+ 

+     sudo dnf install python2-rpkg

+ 

+ If Python 3 package is needed, install `python3-rpkg`.

+ 

+ Install in EL6 or EL7::

+ 

+     sudo yum install python2-rpkg

+ 

+ Install in a Python virtual environment

+ ---------------------------------------

+ 

+ Both Python 2 and 3 packages are published in PyPI. Install rpkg in a Python 3

+ virtual environment in these steps::

+ 

+     python3 -m venv env

+     source env/bin/activate

+     pip install rpkg rpm-py-installer

+ 

+ You are free to create a virtual environment with option ``--system-site-packages``.

+ 

+ Please note that, rpkg depends on some other utilities to build packages. These

+ packages are required to be installed as well.

+ 

+ * ``mock``: for local mockbuild.

+ * ``rpm-build``:  for local RPM build, which provides the command line ``rpm``.

+ * ``rpmlint``: check SPEC.

+ * ``copr-cli``: for building package in `Fedora Copr`_.

+ * ``module-build-service``: for building modules.

+ 

+ .. _`Fedora Copr`: https://copr.fedorainfracloud.org/

+ 

  Contribution

  ============

  

file modified
+6 -1
@@ -7,8 +7,13 @@ 

  koji >= 1.15

  pycurl >= 7.19

  requests

- rpm-py-installer

  six >= 1.9.0

  

+ # rpm-py-installer

+ #

+ # Or, install from rpm-py-installer internal installer

+ # https://github.com/junaruga/rpm-py-installer#install-directly-without-rpm-py-installer-package

+ # python -c "$(curl -fsSL https://raw.githubusercontent.com/junaruga/rpm-py-installer/master/install.py)"

+ 

  # openidc-client # used for MBS OIDC authentication

  # requests-kerberos # used for MBS Kerberos authentication

file modified
+1
@@ -4,6 +4,7 @@ 

  [testenv]

  skip_install = True

  deps =

+     rpm-py-installer

      -r{toxinidir}/requirements/test-pypi.txt

  commands =

      nosetests {posargs}

rpm-py-installer is removed from requires.

Add a new section to documentation for how to install rpkg, which
mentions to install rpm-py-installer with rpkg together.

For running tests, rpm-py-installer is added to deps option.

Fixes #357

Signed-off-by: Chenxiong Qi cqi@redhat.com

is it needed to install both of them?
sudo dnf install python2-rpkg
or
sudo dnf install python3-rpkg

is it needed to install both of them?

No. This is just an example.

But you know ... copy & paste. I was only curious if somebody really needs both versions.

Looks good to me. Can be merged.

rebased onto 257360f

5 years ago

Pull-Request has been merged by cqi

5 years ago