PR#340: Make option --name and --namespace reusable -

rpkg

#340 Make option --name and --namespace reusable

Closed Jun 27, 2018 by cqi. Opened Jun 25, 2018 by cqi.

cqi/rpkg reuse-repo-name-namespace into master

cqi commented Jun 25, 2018

These two options could be reused in other command to get input of
package repository name and/or namespace.

Signed-off-by: Chenxiong Qi cqi@redhat.com

lsedlar commented Jun 25, 2018

Wouldn't the help text for --name be confusing in other cases? It talks about overriding, which may not be relevant elsewhere. But that's not a big deal. :thumbsup:

onosek commented Jun 25, 2018

Interesting information that ArgumentParser can use inheritance. Thanks.

cqi commented Jun 27, 2018

I thought this change could be reused for command request-repo. IMO, the help text could be confusing indeed and should have different content. For the case of request-repo, there would not be too much effort to add --name and --namespace for itself. It's not worth to have this change.

Pull-Request has been closed by cqi

Jun 27, 2018

Metadata

Assignee

None

Tags

No Tags

rpkg

#340 Make option --name and --namespace reusable Closed Jun 27, 2018 by cqi. Opened Jun 25, 2018 by cqi. cqi/rpkg reuse-repo-name-namespace into master

Metadata

#340 Make option --name and --namespace reusable

Closed Jun 27, 2018 by cqi. Opened Jun 25, 2018 by cqi.

cqi/rpkg reuse-repo-name-namespace into master