This is sort of a minimal patch which hooks up koji's 'fail_fast' option, as I requested in #331. All it does is provide a --fail-fast flag, which can be used to turn on that functionality if the server is configured with the build_arch_can_fail option. I have applied this locally and tested against Fedora's koji and the fail_fast option does get propagated into the build and works as expected.
I didn't add any tests. The existing tests still pass, but as various options like --background or --scratch don't appear to be tested, I wasn't sure how to go about it. Given a bit of guidance, I can certainly try to add some tests.
The patch doesn't introduce any PEP8 failures; flake8 for me finds three pre-existing failures in pyrpkg/init.py.
I don't use bash so I didn't touch the bash completion file. I can try if that is necessary. If this is accepted I will provide a patch to the fedpkg zsh completion function.
Signed-off-by: Jason Tibbitts tibbs@math.uh.edu
I think, it is safer appending new parameters then inserting in the middle. I know, these parameters are not positional and hopefully nobody calls this method that way currently. I mean build(False, True, True, ...) So it is only minor suggestion.