PR#311: Use getpass.getuser() instead of pwd.getpwuid(os.getuid())[0] -

rpkg

#311 Use getpass.getuser() instead of pwd.getpwuid(os.getuid())[0]

Merged May 7, 2018 by cqi. Opened May 2, 2018 by jpopelka.

jpopelka/rpkg getpass into master

jpopelka commented May 2, 2018

getpass.getuser() eventually also calls pwd.getpwuid(os.getuid())[0],
but first checks whether there's any of LOGNAME, USER, LNAME and USERNAME
env. variables set. If yes, then it returns its value.

This is useful in Openshift where a container has random uid
and getpwuid(random_uid) fails with:
KeyError: 'getpwuid(): uid not found: random_uid'

Signed-off-by: Jiri Popelka jpopelka@redhat.com

lsedlar commented May 3, 2018

Looks good to me.

ttomecek commented May 3, 2018

I'm trying this locally and still getting an exception:

$ docker run -ti -u 1005 registry.fedoraproject.org/fedora:28 bash
bash-4.4$ python3
Python 3.6.5 (default, Mar 29 2018, 18:20:46)
[GCC 8.0.1 20180317 (Red Hat 8.0.1-0.19)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import getpass
>>> getpass.getuser()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib64/python3.6/getpass.py", line 169, in getuser
    return pwd.getpwuid(os.getuid())[0]
KeyError: 'getpwuid(): uid not found: 1005'
>>>