rpkg

#310 Allow setting custom MBS config file and config section in rpkg.conf.
Merged by lsedlar. Opened by jkaluza.
jkaluza/rpkg mbs-custom-config  into  master

Download 310.patch

This is needed to have different MBS configuration for rhpkg and fedpkg, or even fedpkg and fedpk-stage.

Should this maybe start with a copy of os.environ?
Right now it would reset all existing env variables, which may not be desired.

Other than the empty environment this looks good to me. The failing tests are caused by missing python3.5, which is addressed in #309.

_run_command(...) actually uses os.environ and just adds what's in env to it:

        # Process any environment variables.
        environ = os.environ
        if env:
            for item in env.keys():
                self.log.debug('Adding %s:%s to the environment', item, env[item])
                environ[item] = env[item]

So there is no need to set it explicitly in module_local_build(...).

Looks good to me.

pretty please pagure-ci rebuild

Commit d49c48e6 fixes this pull-request

Pull-Request has been merged by lsedlar

Pull-Request has been merged by lsedlar
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.