rpkg

#291 Add --with and --without options to 'local'
Merged by cqi. Opened by tmz.
tmz/rpkg local-with-without-support  into  master

Download 291.patch

The 'mockbuild' command learned these options in 69b3864 ("Add --with
and --without options to mockbuild", 2017-08-17).

Resolves: rhbz#1533416
Signed-off-by: Todd Zullinger tmz@pobox.com

I ran across https://bugzilla.redhat.com/show_bug.cgi?id=1533416 and thought it might be a relatively easy-fix. I don't have a particular use for it, but if it helps others that's good too. I didn't add a separate test for this as it didn't seem to warrant one. But it shouldn't be too hard to split it out and test separately if desired.

With the localargs support we could also now easily add things like --nocheck or other commonly used rpmbuild options.

pretty please pagure-ci rebuild

@tmz Can you fix the errors? Thanks.

@cqi, the errors are on master, after #295 was merged. I ran git bisect, which tells me " 3f93433b0edadec425074251be67ac3adf446d78 is the first bad commit." I should have just run the tests on master first. I didn't expect that master would be broken. But it appears to be the problem.

@tmz Sorry. That failure test is not relative to your patch. Only the flake8 error needs to be fixed.

rebased onto d94c870fc9fd7942c3bad48d5e0bc926f9cc093d

Ahh, well that's easy. :)

I wrapped the line and updated my local-with-without-support branch.

@tmz Thank you very much. :thumbsup:

Commit bd3fb013 fixes this pull-request

Pull-Request has been merged by cqi

Pull-Request has been merged by cqi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.