#284 Make compose-id and repo-url to take one or more values
Merged 6 years ago by cqi. Opened 6 years ago by csomh.

file modified
+3 -3
@@ -1035,7 +1035,7 @@ 

                             type=int,

                             help='ODCS composes used. '

                                  'Cannot be used with --signing-intent or --repo-url',

-                            nargs='*')

+                            nargs='+')

          group.add_argument(

                            '--signing-intent',

                            help='Signing intent of the ODCS composes. Cannot be '
@@ -1043,9 +1043,9 @@ 

          group.add_argument(

                            '--repo-url',

                            metavar="URL",

-                           help='URL of yum repo file'

+                           help='URLs of yum repo files'

                                 'Cannot be used with --signing-intent or --compose-id',

-                           nargs='*')

+                           nargs='+')

  

          self.container_build_parser.add_argument(

              '--target',

Using nargs='*' help will show something like:

--repo-url [URL [URL ...]]

which reads like the option taking zero or more values.

The above is probably incorrect or at least it does not make
sense from a user point of view, as these options once used
should take one or more space separated values.

Using nargs='+' will fix the above, and help will show the
intended usage:

--repo-url URL [URL ...]

Signed-off-by: Hunor Csomortáni csomh@redhat.com

Makes sense. :thumbsup:

Pull-Request has been merged by cqi

6 years ago
Metadata