#260 Use progress callback and TaskWatcher from koji_cli.lib
Merged by cqi. Opened by cqi.
cqi/rpkg use-koji_cli  into  master

Download 260.patch

As what original author wrote in the comments, it would be good to use
these removed methods and class from a Koji library. For now, they are
available in koji_cli.lib which is shipped along with python[23]-koji
package. It is time to use them from now on.

Signed-off-by: Chenxiong Qi cqi@redhat.com

rebased onto 2b628281716601d3e69268d5a5a031cf4bc78568

Tests are passing for me. Code change looks good to me. It still works with scratch build against both Brew and Koji.

Do you know what's the minimal required koji version for this?

It should be python2-koji-1.30 that is available in Fedora and EPEL. However, we need to wait for new release of Koji in internal.

pretty please pagure-ci rebuild

https://jenkins.fedorainfracloud.org/job/pyrpkg/329/ is triggered manually. Pass.

rebased onto 2d7dde1998f4702c9a4a25028575f9011dffcdab

Rebased only.

ping for review.

Looks good to me. When submitting a scratch build, the waiting still happens correctly.

Commit efbb2dbc fixes this pull-request

Pull-Request has been merged by cqi

Pull-Request has been merged by cqi

Metadata