#255 Ignore TestModulesCli if openidc-client is unavailable
Merged by cqi. Opened by cqi.
cqi/rpkg ignore-openidc-client-in-test  into  master

Download 255.patch

This is for running tests in downstream client when openidc-client is
not used for OpenIDC authentication and not installed in system as well.
Especially the case of building rpkg for RHEL6/7 for rhpkg internal use.
In which case, Kerberos authentication is used instead, and no Python
openidc-client is installed to run tests while building RPM package.

Signed-off-by: Chenxiong Qi cqi@redhat.com

Can this change be removed?

These trailing spaces are required because of https://pagure.io/rpkg/blob/master/f/pyrpkg/init.py#_2740. I've no idea when those trailing spaces were removed, maybe by my editor that is configured to remove trailing whitespaces automatically, but not sure. I think it should be fix whatever in module_build_info or figure out a way to workaround, otherwise it's too inconvenient.

Ok, I was confused by the strip call. That should remove all trailing whitespace.

Pull-Request has been merged by cqi

I think we should revert this and always require openidc because we want all functionality to work regardless of where you get rpkg from. Otherwise we may have to do something like put an epoch in the fedora and EPEL version to make sure it always wins the install race.

@ausil This change is for building rpkg RHEL packages in Brew in order to work with rhpkg together. In internal, Kerberos is used for module build rather than OpenIDC, and there is no Python openidc-client RHEL packages. In Fedora and EPEL, this test will always run because openidc-client has been added to BuildRequires and Requires.

But even if someone installs rpkg build in Brew and fedpkg from EPEL, this combination will still allow building Fedora packages. This really only changes the build requirements, not what happens at runtime.

Metadata