rpkg

#248 Move full download url construction to separate method

Closed Mar 30, 2018 by cqi. Opened Sep 21, 2017 by frostyx.

frostyx/rpkg get-download-url into master

frostyx commented Sep 21, 2017

Can we please have a small method that returns full download URL? I called it get_download_url, but we can change it as you want.
The reason for this PR is that tools using pyrpkg could easily override the method if they want to add some logic into it.

cqi commented Sep 21, 2017

Could you please sign-off on your commit? (git commit -s).

This serves as a confirmation that you have the right to submit your changes. See Developer Certificate of Origin for details.

cqi commented Nov 2, 2017

ping @frostyx

Can you sign-off your commit?

cqi commented Dec 6, 2017

@frostyx is there any case using this change?

cqi commented Mar 21, 2018

This PR will be closed after #297 is merged.

cqi commented Mar 30, 2018