#240 Skip test if rpmfluff is not available
Merged by cqi. Opened by lsedlar.
lsedlar/rpkg disable-rpmfluff  into  master

Download 240.patch

In some environments the rpmfluff package may not be available. In such case the test relying on it should be skipped.

rpmfluff can be installed from either Fedora repo or from git repo directly by pip. What environment need to disable rpmfluff? Or maybe we can mock things to avoid generating a real source rpm.

Internal spec for rpkg has a patch to remove this one test. I just wanted to move it to upstream so that we don't have to update the patch.

Ah, I see, I forgot it. That patch should really be removed.

:thumbsup:

Oh, should we use?

try:
    import unittest2 as unittest
except ImportError:
    import unittest

python-unittest2 is required when running test with Python 2.6.

Good point. I'll update. Adding an extra dependency just for this is not great, though.

rebased onto 1c150879d5db64f73459c82d3445bdfa092a2355

rebased onto 7527dddd7703f7c7f81eb131788ba22202788187

Pull-Request has been merged by cqi

Metadata