rpkg

#236 Fix encoding in new command
Merged by cqi. Opened by cqi.
cqi/rpkg fix-new-diff-encoding  into  master

Download 236.patch

In previous commit, new_diff returned from GitPython API is unicode
string and has to be encoded in encoding UTF-8. That works well with
GitPython>=1.0, but not with version GitPython<1.0 which returns string
in basestring type. This failure case happens in EL6 with
0.3.2-0.6.RC1.el6.

Signed-off-by: Chenxiong Qi cqi@redhat.com

This is found while I'm building EPEL6 package. It was not detected by EL6 Jenkins job, that should be because GitPython 1.x is installed as pip install 'gitpython<2.0.0'

Looks good to me.

rebased

Add a test to test bytestring can be printed in cliClient.new.

Pull-Request has been merged by cqi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.