#231 Compatible with Python 3
Merged by cqi. Opened by cqi.
cqi/rpkg py3  into  master

Download 231.patch
  • Fix code and tests in order to run in Python 3.
  • Add tox to run tests in various Python versions, 2.7 and 3.5 is added currently.
    Original way to run tests with nosetests still works.
  • Fix login_koji_session by using latest koji methods, and it works well with python3-koji now.
  • Add requiremnts files so that it is easier to know what rpkg needs, for either usage or running tests.

1 new commit added

  • Declare Python 3 versions to support in setup.py

1 new commit added

  • Add nosetests to whitelist_externals

9 new commits added

  • Add commands to whitelist_externals
  • Declare Python 3 versions to support in setup.py
  • Replace unicode with six.text_type
  • Run tests in both Python 2 and 3 with tox
  • Make tests and covered code compatible with Py3
  • Add requirements files
  • Do not build srpm in test
  • Do not actually run git-diff in tests
  • Remove deprecated modules used in koji

Looks good to me. Really nice!

Pull-Request has been merged by cqi

Metadata