#174 Fix upload with old PyCURL
Merged by cqi. Opened by lsedlar.
lsedlar/rpkg upload-pycurl  into  master

Download 174.patch

To replicate the crash, use upload command with these versions:

  • pyrpkg 1.47-3.el7.noarch
  • GitPython-1.0.1-5.el7.noarch
  • python-pycurl-7.19.0-19.el7.x86_6

Is it necessary to encode filepath too?

I'm thinking of whether we need to provide a method, maybe named pycurl_safestring, to do the necessary encode.

Another thing is we'd better record each change in the CHANGELOG.rst in same patch.

I think it's not. This issue was always encountered with the name only.

rebased

I updated the changelog as well. There is now a section called NEXT which would be renamed when release is made. What do you think?

It would be nice to get this patch (or similar) out reasonably soon. There have already been two reports since yesterday:

  • https://bugzilla.redhat.com/show_bug.cgi?id=1403925
  • https://pagure.io/fedora-infrastructure/issue/5622

rebased

+1 to both of above.

Pull-Request has been merged by cqi

Metadata