rpkg

#150 Add tests to CLI commands and pyrpkg.Commands
Merged by cqi. Opened by cqi.
cqi/rpkg more-tests  into  master

Download 150.patch
no initial comment

3 new commits added

  • Tests for lookaside related commands
  • More tests to Commands and cliClient
  • Remove unused code

4 new commits added

  • Add tests for import_srpm
  • Tests for lookaside related commands
  • More tests to Commands and cliClient
  • Remove unused code

4 new commits added

  • Add tests for import_srpm
  • Tests for lookaside related commands
  • More tests to Commands and cliClient
  • Remove unused code

4 new commits added

  • Add tests for import_srpm
  • Tests for lookaside related commands
  • More tests to Commands and cliClient
  • Remove unused code

1 new commit added

  • Fix setUp of TestImportSrpm for EL6

5 new commits added

  • Fix setUp of TestImportSrpm for EL6
  • Add tests for import_srpm
  • Tests for lookaside related commands
  • More tests to Commands and cliClient
  • Remove unused code

Okay, it's ready for review now.

Why not use _content = content or ''? This pattern is used in other places in this file?

Actually, does this method do something else than test.utils.Utils.write_file?

Looks great to me.

The tests now need rpmfluff, so it needs to be added as a BuildRequires in spec.

Originally when I ran the tests, I had some failures. They were caused by my locale (cs_CZ), because some of the expected strings were translated. Running the tests via LANG=C python setup.py test fixed them.

1 new commit added

  • Remove unnecessary touch method

touch is removed and replaced with write_file.

1 new commit added

  • Use fake user info to config repository in tests

1 new commit added

  • Make rpmbuild run with local en_US.UTF-8 in tests

Fixed the locale issue. Now, tests don't depend on the local set in the host.

Looked good before, and now it's even better.

Pull-Request has been merged by cqi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.