rpkg

#109 Commit -c should clean up after itself.
Merged by lsedlar. Opened by qwan.
qwan/rpkg clean-temporary-files-after-commit  into  master

Download 109.patch

If we run fedpkg commit with -c (generate the commit message from the
%changelog), it should remove the generated temporary files behind
itself.

Fixes #16

Signed-off-by: Matěj Cepl mcepl@cepl.eu

The failure in Jenkins is caused by too new GitPython. I adjusted the job.

What happens if commit succeeds but tagging fails? It looks like the following will be printed, which is rather confusing (especially given that the commit was actually created):

Could not tag, will not push!
Could not commit, will not tag!
Could not commit, will not push!

However, I don't think that can really happen (because tagging uses -f). Can you see another way tagging could fail?

rebased

@lsedlar I believe you're right, updated the patch.

Looks good, merging.

Pull-Request has been merged by lsedlar
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.