#677 Make the `--allow-empty` flag in `Commands.commit` opt-in or opt-out
Closed: Fixed a year ago by onosek. Opened a year ago by nikromen.

In Copr, when importing package we call the Commands.import_srpm method followed by Commands.commit here. However, if importing a package in Copr is called multiple times and Commands.import_srpm runs and makes no change, the following Commands.commit makes a new commit hash with empty commit, which is unexpected behavior after calling commit multiple times with no changes.

This new behavior was introduced with this commit

It would be nice to have the --allow-empty flag as opt-in or opt-oput.


Thank you for diving deeper into this topic @nikromen!

I can see @onosek proposed a check for autospec in #644. Would it make
sense to eventually implement it (instead of opt-in/opt-out)?

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #688 Merged a year ago