#584 Download source files used as patches when running command 'sources'
Closed: Duplicate 2 years ago by onosek. Opened 2 years ago by jgrulich.

Change https://pagure.io/rpkg/pull-request/564 introduced a check for all source files to be listed in the SPEC file, but it only checks if they are listed as source files. Calling "sources" should also check whether any of uploaded sources is not listed as a patch instead of a source file.


Pull request #581 contains a fix for this issue,
reported earlier in Red Hat Bugzilla as bug 2010518.

Metadata Update from @onosek:
- Issue close_status updated to: Duplicate
- Issue status updated to: Closed (was: Open)

2 years ago

Hi, can you tell when this becomes available in CentOS Stream or in the CI it uses? It blocks me from merging https://gitlab.com/redhat/centos-stream/rpms/qt5-qtbase/-/merge_requests/10.

@jgrulich. Jan, I am not aware of CentOS planning and don't know what CI it uses either.
I can provide a rpkg package with this patch (https://pagure.io/rpkg/c/7ede78f) for Fedora or RHEL.
If the package which is currently used comes from here https://cbs.centos.org/koji/buildinfo?buildID=32035 there shouldn't be the issue.
But if the package comes from an older epel (7/8), the patched release could help.

@onosek do the current versions of rpkg in EPEL/Fedora contain this fix? If not, we should get that released there.

Login to comment on this ticket.

Metadata