#331 RFE: Support koji build --fail-fast
Closed: Fixed 5 years ago Opened 5 years ago by tibbs.

Sometimes (or even most of the time) you want your builds to fail as soon as one architecture fails. In fact, this used to be the default for Fedora's koji instance but many years ago that changed and so it is a common sight to see some build which failed hours ago on x86_64 still grinding away on armv7hl.

As of about nine months ago, koji build supports the --fail-fast flag. Could support for this percolate up to fedpkg in some manner? At least fedpkg build and fedpkg scratch-build could use it. I would even argue that --fail-fast should be the default for scratch-build, if not everywhere, but I suppose that would have to be a separate discussion.

I'll see if I can't come up with a PR for at least the most basic of support. Complete support would probably involve adding --fail-fast and --no-fail-fast flags, and a configuration setting to choose the default. (I would certainly want it enabled for every build I do, scratch or otherwise, and it would be a shame to have to use a shell alias or patch locally.) If that is something which might be accepted, I may need some guidance to get it implemented.

I'll see if I can't come up with a PR for at least the most basic of support.


I would strongly appreciate this option.

I'm now mass rebuilding packages for python 3.7. I go and manually cancel builds that are red+blue (failed already on fast arches, still waiting for arm/s390x to even start) to speed things up. it's tedious. This option would save me a lot of work and/or time.

I submitted PR #332 providing a basic implementation of this.

Pretty please pagure-ci rebuild

Metadata Update from @cqi:
- Issue assigned to tibbs
- Issue set to the milestone: 1.55
- Issue tagged with: RFE

5 years ago

Commit 018a423 fixes this issue

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #346 Merged 5 years ago