Learn more about these different git repos.
Other Git URLs
Koji supports two config options 'serverca' and 'no_ssl_verify' to control how it validates the koji server certificate. This can be overriden in $HOME/.koji/config, but when running via an rpkg based app, these variables are not honoured. The create_koji_session_opts() has not whitelisted them, so they get discarded, causing koji to apply its default behaviour. THis results in SSL verification failure unless the cert is in your global trust store
Patch to fix the config file handling
<img alt="0001-Propagate-serverca-no_ssl_verify-vars-to-Koji-sessio.patch" src="/rpkg/issue/raw/files/367c9d8d0c6d5f3a68cea0f92136579465d5215c63ee0589927be28937bcd8d9-0001-Propagate-serverca-no_ssl_verify-vars-to-Koji-sessio.patch" />
I believe this patch also fixes this problem. <img alt="0001-Use-koji.grab_session_options-rather-than-opencoding.patch" src="/rpkg/issue/raw/db6fb27c858dba8c3c48e4bc7715b29b4428e06921cfdefe835d0292b9e3b262-0001-Use-koji.grab_session_options-rather-than-opencoding.patch" />
Could someone review/merge this?
Oh, or maybe this should be done through a push request ?
Opening a pull request would indeed be helpful. Also, can you please add a sign-off (git commit -s) on the commit? Otherwise the patch looks good.
git commit -s
Opened https://pagure.io/rpkg/pull-request/245
Any update on getting this fix merged... ?
Need to wait for a Koji release that includes https://pagure.io/koji/pull-request/664
https://pagure.io/koji/pull-request/664 has been merged but not released. Move this issue to NEXT.
Metadata Update from @cqi: - Issue set to the milestone: NEXT
https://pagure.io/koji/pull-request/664 is included in next koji release 1.15. See https://pagure.io/koji/pull-request/746
Metadata Update from @cqi: - Issue close_status updated to: Fixed - Issue set to the milestone: 1.53 (was: NEXT) - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.