#195 Doesn't honour the serverca or no_ssl_verify config file options for koji sessions
Closed: Fixed 5 years ago Opened 6 years ago by berrange.

Koji supports two config options 'serverca' and 'no_ssl_verify' to control how it validates the koji server certificate. This can be overriden in $HOME/.koji/config, but when running via an rpkg based app, these variables are not honoured. The create_koji_session_opts() has not whitelisted them, so they get discarded, causing koji to apply its default behaviour. THis results in SSL verification failure unless the cert is in your global trust store

Could someone review/merge this?

Oh, or maybe this should be done through a push request ?

Opening a pull request would indeed be helpful. Also, can you please add a sign-off (git commit -s) on the commit? Otherwise the patch looks good.

Any update on getting this fix merged... ?

Need to wait for a Koji release that includes https://pagure.io/koji/pull-request/664

https://pagure.io/koji/pull-request/664 has been merged but not released. Move this issue to NEXT.

Metadata Update from @cqi:
- Issue set to the milestone: NEXT

5 years ago

Metadata Update from @cqi:
- Issue close_status updated to: Fixed
- Issue set to the milestone: 1.53 (was: NEXT)
- Issue status updated to: Closed (was: Open)

5 years ago

Login to comment on this ticket.