#192 load_module_name incorrectly parses git url ending in slash
Closed: Fixed 7 years ago Opened 7 years ago by lverns.

The troublesome lines are located at __init__.py lines 588-593.

                parts = urllib.parse.urlparse(self.push_url)
                # FIXME
                # if self.distgit_namespaced:
                #     self._module_name = "/".join(parts.path.split("/")[-2:])
                module_name = posixpath.basename(parts.path)

The problem is that parts.path can end in a /. When this occurs, basename will return an empty string.

Git is quite happy working with URLs ending in / (tested in git version 2.10.0).


Metadata Update from @cqi:
- Issue set to the milestone: 1.50

7 years ago

Metadata Update from @cqi:
- Issue assigned to cqi

7 years ago

Metadata Update from @cqi:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

7 years ago

Login to comment on this ticket.

Metadata