#187 Use koji.read_config to read Koji configs
Closed: Fixed 6 years ago Opened 7 years ago by cqi.

koji.read_config would be better than reading koji configs by rpkg itself. Meanwhile, it's easy to select different profile by koji.read_config, e.g.

Read staging or arm configuration

koji.read_config('stg')
koji.read_config('arm')

This requires koji-1.11.0 and fedora-packager-0.6.0.1.


koji.read_config has a little different default configs than rpkg.

  • koji.read_config does not have debug and debug_xmlrpc in its defaults.
  • use_fast_upload defaults to False rather than None.
  • krbservice defaults to host rather than None.

Patch https://pagure.io/koji/pull-request/260 fixes the first.

koji.read_config has a little different default configs than rpkg.

i would say that rpkg defaults are wrong and have not kept up with changes in koji, rpkg partially reimplements the koji cli, mostly due to config parsing from memory.

koji.read_config does not have debug and debug_xmlrpc in its defaults.

not sure it is really necessary.

use_fast_upload defaults to False rather than None.

the result of False and None is the same, Fedora configs now set it to True

krbservice defaults to host rather than None.

rpkg should follow koji here.

Patch https://pagure.io/koji/pull-request/260 fixes the first.

Metadata Update from @cqi:
- Issue set to the milestone: 1.50

7 years ago

Metadata Update from @cqi:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

6 years ago

Login to comment on this ticket.

Metadata