#105 sources needlessly downloads old source file
Closed: Won't fix 5 years ago by onosek. Opened 13 years ago by jkeating.

When updating a spec file to a new source, but before the new source has been uploaded, rpkg may wind up needlessly downloading the source file in sources. It should perhaps peek at the spec file and decide if a new source file is already downloaded. Or something...?


Is this still a problem nowadays? Build commands will fail even if old source file is downloaded, because newer version of source file will be searched and then fail.

Probably a warning message could be printed if source files listed in sources are not present in SPEC.

Metadata Update from @cqi:
- Assignee reset
- Issue close_status updated to: None
- Issue set to the milestone: 1.58
- Issue tagged with: RFE

6 years ago

Metadata Update from @cqi:
- Issue untagged with: RFE
- Issue set to the milestone: None (was: 1.58)

6 years ago

Similar to: https://pagure.io/fedpkg/issue/34, which was closed. Resolve it here.

This issue has been unresolved for more than a year, and is going to be closed within a week if no further action is taken. If you feel this is in error, please contact me.
This is a cleaning process suggested by Jay Greguske. Copy of this ticket was already closed in JIRA tracker.

I think I'm in a similar situation and I'm confused.
My sources file is still showing an old version. Before upgrading it with fedpkg new-sources I must download the new source tarball. I've already upgraded the version in my .spec file and commited the changes. I would expect fedpkg sources to download the version specified in the .spec file instead of those in sources file.

I had to use spectool -g file.spec and then fedpkg new-sources file.tar.gz.

That expectation is not correct. Fedpkg never downloads upstream sources. It will simply downloads whatever was uploaded to lookaside cache and is listed in sources file.

To download from upstream, spectool should indeed be used.

Metadata Update from @onosek:
- Issue close_status updated to: Won't fix
- Issue status updated to: Closed (was: Open)

5 years ago

Log in to comment on this ticket.

Metadata