robosignatory

Clone
Source Code
GIT

#45 Set directories created for OSTree refs to be group writable
Merged 5 years ago by abompard. Opened 5 years ago by dustymabe.
dustymabe/robosignatory dusty-ostree-dir-group-write  into  master

file modified
+7 -1 
@@ -50,7 +50,13 @@ 
 

      dirname_refpath = os.path.dirname(refpath)
 

      if doref and not os.path.exists(dirname_refpath):
 

          log.info("Creating the directories for the refpath")
 

-         os.makedirs(dirname_refpath)
 

+         # Set the umask to be more permissive so directories get group write
 

+         # permissions. See https://pagure.io/releng/issue/8811#comment-629051
 

+         oldumask = os.umask(0o0002)
 

+         try:
 

+             os.makedirs(dirname_refpath)
 

+         finally:
 

+             os.umask(oldumask)
 

  

      if doref:
 

          log.info('Writing %s to %s' % (commitid, refpath))

We need to set the umask to be more permissive so directories get group write
permissions. See https://pagure.io/releng/issue/8811#comment-629051.

I dont know the full code base, but otherwise its LGTM

@abompard @kevin @jlebon - can I get a review on this?

Looks reasonable to me!

seems ok.

can we merge and schedule to get this deployed (after freeze)?

Pull-Request has been merged by abompard
5 years ago
Metadata
None
No Tags
Changes Summary 1
+7 -1
file changed
robosignatory/work.py
Powered by Pagure 5.14.1
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.