#7646 FTBFS fixes
Merged 4 years ago by mohanboddu. Opened 5 years ago by mohanboddu.
mohanboddu/releng ftbfs_fixes  into  master

@@ -96,9 +96,11 @@ 

          attach_logs(bug, logs)

      except Fault as ex:

          print(ex)

-         #sometimes there wont be BZ component, for ex: Fedora-KDE-Live

-         #skip those packages/components

+         #Because of having image build requirement of having the image name in koji

+         #as a package name, they are missing in the components of koji and we need

+         #to skip them.

          if ex.faultCode == 51:

+         #if "There is no component" in ex.faultString:

              print(ex.faultString)

              return None

          else:
@@ -137,9 +139,9 @@ 

  

          filesize = fp.tell()

          # Bugzilla file limit, still possibly too much

-         # FILELIMIT = 20000 * 1024

-         # Just use 1 MiB:

-         FILELIMIT = 2 ** 10

+         # FILELIMIT = 32 * 1024

+         # Just use 32 KiB:

+         FILELIMIT = 2 ** 15

          if filesize > FILELIMIT:

              fp.seek(filesize - FILELIMIT)

              comment = "file {} too big, will only attach last {} bytes".format(
@@ -164,6 +166,8 @@ 

  def get_filed_bugs(tracking_bug):

      """Query bugzilla if given bug has already been filed

  

+     arguments:

+     tracking_bug -- bug used to track failures

      Keyword arguments:

      product -- bugzilla product (usually Fedora)

      component -- component (package) to file bug against

@@ -53,6 +53,7 @@ 

          "tracking_bug": 1602938,  # Tracking bug for mass build failures

          "wikipage": "https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild",

          "pkg_skip_list": PKG_SKIP_LIST,  # packages to skip in rebuild

+         "current_rawhide": "29",

      },

      "f28":

      {

no initial comment

Dont merge it yet. Still needs some fixes

1 new commit added

  • Skip packages with no components in BZ and increase the size of logs
5 years ago

All done for the review.

IMHO it would be easier to understand if this is if "There is no component" in ex.faultString: with the return statement and the login code in the else part.

The comment above also needs to be adjusted to 32 kiB then (initially it should have been 2**20but I guess 2 ** 15 is good, too.

@mohanboddu can you rebase and address @till 's last comments?

rebased onto 527c6ad

4 years ago

3 new commits added

  • Increase the size of logs and better comments
  • FTBFS fixes for comments
  • FTBFS - Check if the bug has already been filed
4 years ago

Pull-Request has been merged by mohanboddu

4 years ago