#6845 Explaining why we unblock pkgs on epel build tag
Merged 6 years ago by kellin. Opened 6 years ago by mohanboddu.
mohanboddu/releng block-retired-epel-comment  into  master

@@ -222,6 +222,9 @@ 

      cmd = ["block-pkg", tag] + packages

      catch_koji_errors(cmd)

  

+     #If a package moves from EPEL to RHEL it can only be built if it is unblocked

+     #in the epel build tag. Therefore unblock all retired EPEL packages in the

+     #built tag since it does not hurt if the package does not move to RHEL.

      if epel_build_tag:

          cmd = ["unblock-pkg", epel_build_tag] + packages

          catch_koji_errors(cmd)

I would reword the comment like this:

If a package moves from EPEL to RHEL it can only be built if it is unblocked in the epel build tag. Therefore unblock all retired EPEL packages in the built tag since it does not hurt if the package does not move to RHEL.

@mohanboddu I will merge this if you could update with the comment above and then re-base to get the merge button on green light.

rebased onto 20de921aa82d3248305df1218f6294c90d106bf1

6 years ago

rebased onto a704481

6 years ago

Pull-Request has been merged by kellin

6 years ago
Metadata