#6728 Adding keytab for koji session login
Closed 3 years ago by ausil. Opened 3 years ago by mohanboddu.
mohanboddu/releng block-retired-profiles  into  master

file modified
+6 -1
@@ -95,7 +95,12 @@ 

      profile = PRODUCTION_KOJI_PROFILE if not staging else STAGING_KOJI_PROFILE

      koji_module = koji.get_profile_module(profile)

      kojisession = koji_module.ClientSession(koji_module.config.server)

-     kojisession.krb_login()

+     # Compose profile has keytab set which can be used to create koji session

+     # Nightly composes requires the koji session created using keytab to do koji blocking.

+     if profile == "compose_koji":

+         kojisession.krb_login(keytab=koji_module.config.keytab)
ausil commented 3 years ago

can we just check if koji_module.config.keytab exists or is not empty? does it actually work?

+     else:

+         kojisession.krb_login()

      pkglist = kojisession.listPackages(tagID=tag, inherited=True)

      blocked = []

      unblocked = []

Nightly composes require koji session created using
keytab to perform koji blocking of retired packages.

Signed-off-by: Mohan Boddu mboddu@redhat.com

can we just check if koji_module.config.keytab exists or is not empty? does it actually work?

@ausil I did not do it that way because, if a new profile is created with a different keytab. Then it will run it using that keytab(assuming that profile is passed as an argument). If it is how you want the script to execute, then I can change it as per your request.

the config file would point at the correct location for a different profile

closing this request as it does not fix the problem.

closing this request as it does not fix the problem.

closing this request as it does not fix the problem.

Pull-Request has been closed by ausil

3 years ago
Metadata