#9961 Extend support for branch 13 for modules/postgresql
Closed: Fixed 3 years ago by hhorak. Opened 3 years ago by hhorak.

Originally requested in https://pagure.io/releng/fedora-scm-requests/issue/31794, but without success.

The support for branch 13 in modules/postgresql was requested wrong, and we now get git push error when trying to push to the branch:

$ git push
Enumerating objects: 5, done.
Counting objects: 100% (5/5), done.
Delta compression using up to 8 threads
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 368 bytes | 368.00 KiB/s, done.
Total 3 (delta 1), reused 0 (delta 0), pack-reused 0
remote: Branch refs/heads/13 is unsupported
remote: Denied push for ref 'refs/heads/13' for user 'hhorak'
remote: All changes have been rejected
To ssh://pkgs.fedoraproject.org/modules/postgresql
 ! [remote rejected] 13 -> 13 (pre-receive hook declined)
error: failed to push some refs to 'ssh://hhorak@pkgs.fedoraproject.org/modules/postgresql'

I'd like to request extending the support to 2022/12/31.


Metadata Update from @smooge:
- Issue tagged with: medium-gain, medium-trouble, ops

3 years ago

@hhorak It should be fixed now, give it a try.

Metadata Update from @mohanboddu:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

3 years ago

Awesome, works. Thanks!

And it stopped working again. Not sure whether it was caused by creating a new stream branch for pgaudit (https://pagure.io/releng/fedora-scm-requests/issue/31987), but it is weird that what was fixed a week ago is changed back in few days.

Same issue reported for pgaudit as well: https://pagure.io/releng/issue/9982

Anyway, I don't see why push to a branch would be prohibited at all in case the stream branch is supposed to be not supported. I think it is ok to push an extra update even when the stream branch is marked EOL. I'd personally remove the check entirely for the stream branches.

$ git branch
  add-ci-plan
  enable-jit
  f26
  f27
  f29
  f30
  f32
  f33
  master
  pgsql-setup-8.5
  private-hhorak-pgsql96upgrade
  private-stream-postgresql-12
  private-stream-postgresql-12-scl
  stream-postgresql-10
  stream-postgresql-11
  stream-postgresql-12
* stream-postgresql-13
  stream-postgresql-9.6
[hhorak@hhorak-t490s postgresql] (stream-postgresql-13 %)$ git push
Enumerating objects: 9, done.
Counting objects: 100% (9/9), done.
Delta compression using up to 8 threads
Compressing objects: 100% (7/7), done.
Writing objects: 100% (7/7), 1.33 KiB | 341.00 KiB/s, done.
Total 7 (delta 4), reused 0 (delta 0), pack-reused 0
remote: Branch refs/heads/stream-postgresql-13 is unsupported
remote: Denied push for ref 'refs/heads/stream-postgresql-13' for user 'hhorak'
remote: All changes have been rejected
To ssh://pkgs.fedoraproject.org/rpms/postgresql
 ! [remote rejected] stream-postgresql-13 -> stream-postgresql-13 (pre-receive hook declined)
error: failed to push some refs to 'ssh://hhorak@pkgs.fedoraproject.org/rpms/postgresql'

Metadata Update from @hhorak:
- Issue status updated to: Open (was: Closed)

3 years ago

And it stopped working again. Not sure whether it was caused by creating a new stream branch for pgaudit (https://pagure.io/releng/fedora-scm-requests/issue/31987), but it is weird that what was fixed a week ago is changed back in few days.

I dont think so

Same issue reported for pgaudit as well: https://pagure.io/releng/issue/9982

This is for rpms/postgresql for branch stream-postgresql-13 not pgaudit

Anyway, I don't see why push to a branch would be prohibited at all in case the stream branch is supposed to be not supported. I think it is ok to push an extra update even when the stream branch is marked EOL. I'd personally remove the check entirely for the stream branches.

Are you sure you are pushing to the modules namespace, I think you are pushing to rpms but I fixed https://pagure.io/releng/issue/9982 just now, so for branch stream-postgresql-13 for rpms/postgresql should also work now.

Sorry for the confusion, I was obviously smoking something weird, can't recall why I mixed the components that way ;) Hope it will be good now. Thanks!

Metadata Update from @hhorak:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

3 years ago

Login to comment on this ticket.

Metadata
Boards 1
Ops Status: Backlog