#9874 Container builds in rawhide get tagged directly in f34-container
Closed: Fixed 3 years ago by mohanboddu. Opened 3 years ago by cverna.

  • Describe the issue

A layered image container built again rawhide will get tagged directly to f34-container, which means that we can create updates in bodhi.
Bodhi want the builds to be tagged with the candidate tag f34-container-updates-candidate

I think we need to change the target tag in koji or something like that :stuck_out_tongue:

  • When do you need this? (YYYY/MM/DD)

  • When is this no longer needed or useful? (YYYY/MM/DD)

  • If we cannot complete your request, what is the impact?


Okay, I am confused

that we can create updates in bodhi. I think you mean to say that we can't create updates in bodhi.

So, the reason why we are not doing it this way is we didn't enable gating on container builds for rawhide, if we think that is useful then we can definitely enable it and ask maintainers to add the tests.

Okay, I am confused

me too :)

that we can create updates in bodhi. I think you mean to say that we can't create updates in bodhi.

We need a way to move container images from the candidate-registry to registry.fp.o, currently this done by bodhi for other releases than rawhide.
I am not aware of anything that does that for rawhide, so I think we need to be able to do updates for rawhide.

So, the reason why we are not doing it this way is we didn't enable gating on container builds for rawhide, if we think that is useful then we can definitely enable it and ask maintainers to add the tests.

More than the tests or gating we need something to move images from candidate-registry.fp.o to registry.fp.o
Currently building a container image for rawhide in OSBS will results in having that image stuck forever in the candidate-registry or do we have something else moving these images ?

Metadata Update from @mohanboddu:
- Issue tagged with: medium-gain, medium-trouble, ops

3 years ago

@cverna I updated the target to tag the container builds to updates-candidate tag.

$ koji edit-target f34-container-candidate --dest-tag f34-container-updates-candidate
$ koji edit-target rawhide-container-candidate --dest-tag f34-container-updates-candidate

There are currently few containers in f34-container tag

$ koji list-tagged f34-container                                                              560ms  Thu 03 Dec 2020 09:01:05 PM UTC
Build                                     Tag                   Built by
----------------------------------------  --------------------  ----------------
fedora-toolbox-34-3                       f34-container         petersen
fedora-toolbox-34-5                       f34-container         rishi
fedora-toolbox-34-6                       f34-container         harrymichal
flatpak-build-base-1-2                    f34-container         cverna
grafana-6-3                               f34-container         agerstmayr
pcp-5-5                                   f34-container         agerstmayr
pcp-5-6                                   f34-container         agerstmayr
tools-0-20.f27container                   f34-container         cverna
tools-0-21.f27container                   f34-container         cverna
trojan-0-4                                f34-container         yanqiyu

Should I move them to f34-container-updates-candidate tag and create bodhi updates for them?

No think this is fine, it is easy to do a new build if needed :)

Thanks mohan.

Metadata Update from @cverna:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

3 years ago

So, since this change there has been a F34C updates push that has nothing in it and gets removed on resume...

<Compose: F34C testing> has no updates. It is being removed.

Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]: [2020-12-06 01:19:18,767: INFO/ForkPoolWor
ker-3] Thread(f34-container-updates-testing) finished.  Success: False                                              Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]: [2020-12-06 01:19:18,909: INFO/ForkPoolWor
ker-3] Compose object updated.                                                                                      Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]: [2020-12-06 01:19:18,909: ERROR/ForkPoolWo
rker-3] ComposerThread failed. Transaction rolled back.                                                             Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]: Traceback (most recent call last):        
Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]:   File "/usr/lib/python3.8/site-packages/koji/__init__.py", line 2754, in _callMethod                                                                         
Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]:     return self._sendCall(handler, headers, request)                                                                                                          
Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]:   File "/usr/lib/python3.8/site-packages/koji/__init__.py", line 2672, in _sendCall                                                                           
Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]:     return self._sendOneCall(handler, headers, request)                                                                                                       
Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]:   File "/usr/lib/python3.8/site-packages/koji/__init__.py", line 2718, in _sendOneCall                                                                        
Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]:     ret = self._read_xmlrpc_response(r)   Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]:   File "/usr/lib/python3.8/site-packages/k
oji/__init__.py", line 2730, in _read_xmlrpc_response                                                               Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]:     result = u.close()                    
Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]:   File "/usr/lib64/python3.8/xmlrpc/client.py", line 655, in close                                                                                            
Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]:     raise Fault(**self._stack[0])         Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]: xmlrpc.client.Fault: <Fault 1003: 'build p
cp-5-4 not in tag f34-container-updates-testing-pending'>                                                           Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]: During handling of the above exception, an
other exception occurred:                                                                                           Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]: Traceback (most recent call last):        
Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]:   File "/usr/lib/python3.8/site-packages/bodhi/server/tasks/composer.py", line 325, in run                                                                    
Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]:     self.work()                           Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]:   File "/usr/lib/python3.8/site-packages/b
odhi/server/tasks/composer.py", line 388, in work                                                                   Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]:     self.determine_and_perform_tag_actions
()                                                                                                                  Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]:   File "/usr/lib/python3.8/site-packages/b
odhi/server/tasks/composer.py", line 75, in wrapper                                                                 Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]:     retval = method(self, *args, **kwargs)
Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]:   File "/usr/lib/python3.8/site-packages/bodhi/server/tasks/composer.py", line 548, in determine_and_perform_tag_actions                                      
Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]:     self._determine_tag_actions()         Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]:   File "/usr/lib/python3.8/site-packages/b
odhi/server/tasks/composer.py", line 574, in _determine_tag_actions                                                 Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]:     self.eject_from_compose(update, reason
)                                                                                                                   Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]:   File "/usr/lib/python3.8/site-packages/b
odhi/server/tasks/composer.py", line 483, in eject_from_compose                                                     Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]:     update.remove_tag(update.release.pendi
ng_testing_tag,                                                                                                     Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]:   File "/usr/lib/python3.8/site-packages/b
odhi/server/models.py", line 3093, in remove_tag                                                                    Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]:     koji.untagBuild(tag, build.nvr, force=
True)                                                                                                               
Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]:   File "/usr/lib/python3.8/site-packages/k
oji/__init__.py", line 2346, in __call__                                                                            
Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]:     return self.__func(self.__name, args, 
opts)                                                                                                               
Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]:   File "/usr/lib/python3.8/site-packages/k
oji/__init__.py", line 2773, in _callMethod                                                                         
Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]:     raise err                             
Dec 06 01:19:18 bodhi-backend01.iad2.fedoraproject.org celery-3[1835185]: koji.TagError: build pcp-5-4 not in tag f3
4-container-updates-testing-pending

Metadata Update from @kevin:
- Issue status updated to: Open (was: Closed)

3 years ago

I revoked the bodhi update since there were newer pcp container builds were pushed.

Metadata Update from @mohanboddu:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

3 years ago

Login to comment on this ticket.

Metadata
Boards 1
Ops Status: Done