#9809 Drop special restictions on fedora-release
Closed: Fixed 2 years ago by mohanboddu. Opened 2 years ago by zbyszek.

This is a continuation of https://pagure.io/releng/issue/7612.

The package is now accessible to proven-packagers and allows pull requests (yay, 21st century), but some restrictions remain. In particular, if pps can commit but not build this creates a trap. There is really no reason for this, so please drop the remaining bits of legacy baggage:

  1. drop the comment that "The package can only be built by a very small number of people if you are not sure you can build it do not attempt to" and the restriction in pertains to.
  2. drop the requirement for "signed-off-by". Fedora packages don't require this. All contributors must sign a contributor agreement. This is just cargo-culting of something that makes (some) sense for the kernel where anyone can send in a patch, but not for a tightly regulated project like Fedora.

Also technically, there is nothing to sign off in the repo.

I've done 2.
For 1, you can send a PR.

Personally, I completely agree with 2, but it seems odd of you to just unilaterally do it yourself without discussion. (Or was there some I missed?)

For one, yes, we removed this restriction...

I have assumed we previously agreed we want to lift all the restrictions. If that was not the case, I apologize for misunderstanding.

Oh, perhaps I am not remembering all we agreed to. :)

In any case I am +100 to these changes myself. If @mohanboddu and @humaton don't have any objections lets make it so!

I've toggled the option back (in fedora-repos and fedora-release). It was not my intention to force it and I'll gladly wait for @mohanboddu and @humaton.

We removed the package from secure-boot channel and at that time we might have agreed to it, but I dont recall, anyway, in our stand up today, we agreed to both 1 and 2.

I merged the PR and removed the sign-off requirement.

Metadata Update from @mohanboddu:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

2 years ago

Login to comment on this ticket.