#9565 Releng assessment of change: Patches in Forge macros - Auto macros - Detached rpm changelogs
Closed: Fixed 7 months ago by mohanboddu. Opened 10 months ago by nim.

As required by our change process, this ticket requests releng assessment of the following system-wide F33 change proposal:

https://fedoraproject.org/wiki/Changes/Patches_in_Forge_macros_-_Auto_macros_-_Detached_rpm_changelogs


@nim This looks like it should be included in mass rebuild, can you confirm?

Metadata Update from @mohanboddu:
- Issue tagged with: changes, f33

10 months ago

A lot of this is new code, and specs need to be changed to use the new features before it affects them.

The exceptions are
1. specs using forge macros
2. go and font packages

For forge macros, there is an extensive compatibility layer, though it would be nice to exercise it during the mass rebuild to check it handles all existing specs (however if some spec break I’ll just convert them to the new syntax. Changing forgeurl to forge_url is way easier than debugging complex compatibility macro code)

The copr posted in the change already contains a conversion of most affected font packages to the new syntax (there are maybe a dozen max packages I did not convert but that’s easy to do)

Go packages are both easier and harder. Harder, because there is a huge amount of them, and because conversion to go modules that will use the new syntax is not scheduled before F34.

Easier, because they all call forge macros through the go macros, and I control that in Fedora, so it’s quite easy to switch the go to forge interfacing here.

So basically the only part that is a little risky and that is worth exercising in a mass rebuild is any spec that contains the %forgemeta call today. That can be done either during the general mass rebuild or in a separate side tag.

Of course, since I do not like fixing problems in crash and burn mode any more than the next guy, I would try to do some premptive side tag testing (if someone could tell me how to get my hands on an archive of all current Fedora specs, so I could check which of those use forgemeta without having to fedpkg clone several thousands of git repositories)

Of course, since I do not like fixing problems in crash and burn mode any more than the next guy, I would try to do some premptive side tag testing (if someone could tell me how to get my hands on an archive of all current Fedora specs, so I could check which of those use forgemeta without having to fedpkg clone several thousands of git repositories)

specs: https://src.fedoraproject.org/lookaside/rpm-specs-latest.tar.xz (12MB)
git checkout seed of all packages: https://src.fedoraproject.org/lookaside/git-seed-latest.tar.xz (12GB)

@kevin sorry, I missed the answer notification

Thank you very much for the pointers, I will attempt to set up a pre-check mass build now

This change is not approved, so we are not including it in mass rebuild.

Closing this ticket, please reopen a new one with the updated change proposal.

Thanks.

Metadata Update from @mohanboddu:
- Issue untagged with: changes, f33
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

7 months ago

Login to comment on this ticket.

Metadata