#9481 Please remove "tests-public_content" branch from "rpms/setroubleshoot"
Closed: Can't Fix 3 years ago by mohanboddu. Opened 3 years ago by plautrba.

  • Describe the issue

I've accidentally pushed "tests-public_content" branch directly into "rpms/setroubleshoot" - https://src.fedoraproject.org/rpms/setroubleshoot/tree/tests-public_content

Please remove it.

  • When do you need this? (YYYY/MM/DD)

2020/10/01

  • When is this no longer needed or useful? (YYYY/MM/DD)

It would be always useful.

  • If we cannot complete your request, what is the impact?

Nothing, just a branch in repository


Use https://pagure.io/fesco/issue/2340#comment-625970 to identify whether the branch is removable or not.

Metadata Update from @mohanboddu:
- Issue tagged with: groomed, medium-gain, medium-trouble

3 years ago
$ BRANCH=tests-public_content                                                       

$ if git rev-list origin/master | grep `git rev-parse remotes/origin/$BRANCH` ; then
    echo "OK to remove" ; else
    echo "NOT ok to remove" ;
fi
NOT ok to remove

I'm not sure what reachable means in this context and why it's important. I accidentally created "tests-public_content" branch when I used git push origin HEAD instead git push myfork HEAD. The branch is in the correct repo now - https://src.fedoraproject.org/fork/plautrba/rpms/setroubleshoot/tree/tests-public_content . "tests-public_content" branch in "rpms/setroubleshoot" repository is not used for anything.

I'm not sure what reachable means in this context and why it's important.

@plautrba this means, there is a commit in tests-public_content branch that is not accessible from master branch. And that commit is

https://src.fedoraproject.org/rpms/setroubleshoot/c/5030a7a1a66d6f1ce47690e5dc94a1fd56372a49?branch=tests-public_content

If you merge the above commit with master then we will be able to remove the branch.

The reason why we have this check is, we dont have a method right now that tracks what build is submitted from what hash, so we added this check so that if the commits from the removable branch is accessible from master branch, then we can remove the branch. Hope that makes sense.

I see. I could merge it but then I would need to revert it. It was supposed to be a testing commit used only in PR and Fedora CI run based on this commit failed due to dependency problems. There's no build based on this commit. I don't really want to populate master branch with this commit so if you have no option how to remove it I'll leave it, or maybe add another commit to this branch which will remove all the content in order not to confuse future me.

Yeah, we cannot remove it unless it satisfies the policy. Let us know if you change your mind.

Metadata Update from @mohanboddu:
- Issue close_status updated to: Can't Fix
- Issue status updated to: Closed (was: Open)

3 years ago

Login to comment on this ticket.

Metadata