#9116 F32 change, enable fstrim.timer
Closed: Fixed 4 years ago by mohanboddu. Opened 4 years ago by chrismurphy.

  • Describe the issue

There will be a system-wide change proposal to enable fstrim.timer by default starting with Fedora 32; once FESCo approves, let me know whether to:

a. file a bugzilla requesting the change to fedora-release package
b. submit a PR with the change to
https://src.fedoraproject.org/rpms/fedora-release/blob/master/f/90-default.preset

It would look something like this:

# Enable fstrim.timer, approved by FESCo ticket#xxxxx
enable fstrim.timer
  • When do you need this? (YYYY/MM/DD)

If approved by FESCo, I'm guessing before branch, so that it's in Rawhide as well as F32? Schedule says "Branch Fedora 32 from Rawhide" is 2020-02-11

  • When is this no longer needed or useful? (YYYY/MM/DD)

2020-02-12

  • If we cannot complete your request, what is the impact?

No big deal. Feature benefit delayed until Fedora 33.


Is there a policy on what the upgrade behavior is/should be for changes in vendor presets? I found in the Workstation PRD "upgrade process should give a result that is the same as an original install " which suggests it should be enabled on upgrade. The intention for the change proposal is to enable it for new installs and upgrades, but what's generally expected or required?

If I change 90-default.preset as described above on an existing system and reboot, the timer unit doesn't actually get enabled until I do systemctl preset fstrim.timer. But I'm not sure if an upgrade resets units to vendor preset value, or if I need to do something to make that happen?

Is there a policy on what the upgrade behavior is/should be for changes in vendor presets? I found in the Workstation PRD "upgrade process should give a result that is the same as an original install " which suggests it should be enabled on upgrade. The intention for the change proposal is to enable it for new installs and upgrades, but what's generally expected or required?

It is expected that new defaults take effect on upgrade, when presets are re-evaluated. After the fact, if the user wishes the disable, then systemd honors it.

If I change 90-default.preset as described above on an existing system and reboot, the timer unit doesn't actually get enabled until I do systemctl preset fstrim.timer. But I'm not sure if an upgrade resets units to vendor preset value, or if I need to do something to make that happen?

If the user has done no action prior, the preset takes effect. Otherwise, it does not.

The proposal says If the user/admin wants fstrim to apply to all mounted file systems, they should copy the original fstrim.service unit file …. Wouldn't it be a better recommendation to suggest creating a file /etc/systemd/system/fstrim.service.d/allmounts.conf containing only a modified ExecStart line?

@goeran That, or using sudo systemctl edit fstrim.service with the modified ExecStart line, which then creates /etc/systemd/system/fstrim.service.d containing override.conf

Yes, that is probably even better.

Done, thanks for the suggestion.

Metadata Update from @mohanboddu:
- Issue tagged with: changes, f32

4 years ago

Metadata Update from @mohanboddu:
- Issue tagged with: change-ack

4 years ago

Closing this as the PR has been merged.

Metadata Update from @mohanboddu:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

4 years ago

Login to comment on this ticket.

Metadata