Learn more about these different git repos.
Other Git URLs
When a nonpackager is working towards being a packager, they are often asked by their future sponsors to do some informal reviews. When doing it, sometimes they go to far and they actually set the fedora-review+ flag. This should not be possible. When the repo is requested via fedora-scm-requests, it sees the fedora-review+ flag and creates the repo.
Example: https://bugzilla.redhat.com/show_bug.cgi?id=1766860#c4
I'm 99 % sure this wasn't possible in the past, however, not sure how far ago that was.
When do you need this? as always, sooner the better, no actual deadline
When is this no longer needed or useful? when we let nonpackagers to do reviews
If we cannot complete your request, what is the impact? nonpackagers doing reviews
Odd. I thought the fedscmadmin tool checked that the person assigned the bug was a packager and rejected it if not.
Perhaps this check is broken along the way. ;(
FYI: The old code when we had packagedb checked this: https://github.com/fedora-infra/packagedb-cli/blob/master/pkgdb2client/utils.py#L310
ok, so I guess this is a fedscmadmin bug. Can someone open a ticket there or propose a PR/fix?
Metadata Update from @syeghiay: - Issue assigned to mohanboddu
I will move this ticket to fedscm-admin and to verify who set the flag, we will use packager fas group.
packager
So, it seems we are already checking it
https://pagure.io/fedscm-admin/blob/master/f/fedscm_admin/bugzilla.py#_170
And I just added a test case for it as well
https://pagure.io/fedscm-admin/pull-request/33
Maybe, limb ran it with --force which might have skipped the check?
Closing it as we think it was run by --force option.
Metadata Update from @mohanboddu: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.