#8851 RFE: When the retirement commit is reverted before a package gets blocked, don't block it
Closed: Get back later 4 years ago by mohanboddu. Opened 4 years ago by churchyard.

This is an RFE.

Current behavior:

  1. packager pushes fedpkg retire to package P
  2. packager realizes this was a mistake and quickly pushes git revert to package P
  3. the (daily?) script that blocks packages blocks package P from Koji
  4. somebody still needs to open a releng ticket, such as https://pagure.io/releng/issue/8849

Requested behavior:

  1. packager pushes fedpkg retire to package P
  2. packager realizes this was a mistake and quickly pushes git revert to package P
  3. the (daily?) script that blocks packages does not block package P from Koji

Note that the following behavior should stay:

  1. packager pushes fedpkg retire to package P
  2. the (daily?) script that blocks packages blocks package P from Koji
  3. packager realizes this was a mistake and they still need to open a releng ticket

To clairfy here... currently:

Current behavior:

packager pushes fedpkg retire to package P

fedmsg listener sees the 'dead.package' commit and blocks the package in koji.

packager realizes this was a mistake and quickly pushes git revert to package P
the (daily?) script that blocks packages blocks package P from Koji
somebody still needs to open a releng ticket, such as https://pagure.io/releng/issue/8849

So, we would need to teach the listener to unblock on reverts... but that would also allow anyone to just revert it.

fedmsg listener sees the 'dead.package' commit and blocks the package in koji.

Kinda, the listener updates the eol date in pdc and then https://pagure.io/releng/blob/master/f/scripts/block_retired.py will run nightly which will look at the pdc values to block them in koji.

So, git revert should undo the set eol date in pdc.

Metadata Update from @mohanboddu:
- Issue tagged with: automation

4 years ago

ah yeah, you are right. :) Thanks for clarifying @mohanboddu

Metadata Update from @kevin:
- Issue untagged with: automation

4 years ago

It would be actually awesome, if the git revert would update PDC and unblock the package in Koji iff the dead.package commit came in no longer than 8 weeks before it.

Metadata Update from @mohanboddu:
- Issue tagged with: meeting

4 years ago

This has been fixed but not possible in the way that everyone wants. With the change, people cannot revert the retirement commit, they have to go through unretirement process.

Metadata Update from @mohanboddu:
- Issue close_status updated to: Get back later
- Issue status updated to: Closed (was: Open)

4 years ago

Login to comment on this ticket.

Metadata