Learn more about these different git repos.
Other Git URLs
Name of the package? thrift
FAS username of the new maintainer? ctubbsii
Branches that you need it to be unretired for? master (and f31 if that's branched before unretiring)
Package re-review BZ URL? N/A (under 8 weeks since automatic retirement)
Any extra information? Package was forcibly retired because of python2 dependency causing FTBFS. The dependency on python2 is from an optional component that can be removed or disabled in order to make the package build.
Hi, the package has been unretired for rawhide and f31.
Metadata Update from @humaton: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
The package was not transferred to the new maintainer (ctubbsii), so this action is not yet complete.
Metadata Update from @ctubbsii: - Issue status updated to: Open (was: Closed)
Also, it is still blocked:
$ koji list-pkgs --show-blocked --tag f32 --package thrift Package Tag Extra Arches Owner ----------------------- ----------------------- ---------------- --------------- thrift f32 releng [BLOCKED]
There also doesn't appear to be a f31 branch.
Sorry for the mess all should be set now.
Sorry, almost, but not quite. There's still no f31 branch.
I tried to make one myself, but that didn't work (I didn't really expect it to):
git checkout -b f31 master git push -u origin f31
That only resulted in:
Total 0 (delta 0), reused 0 (delta 0) remote: Unspecified ref refs/heads/f31 is blocked remote: Denied push for ref 'refs/heads/f31' for user 'ctubbsii' remote: All changes have been rejected To ssh://pkgs.fedoraproject.org/rpms/thrift ! [remote rejected] f31 -> f31 (pre-receive hook declined) error: failed to push some refs to 'ssh://ctubbsii@pkgs.fedoraproject.org/rpms/thrift'
Please use fedpkg request-branch for requesting new branches.
@ctubbsii So here is the difference:
Sometimes, package is retired in multiple branches, see for example:
https://src.fedoraproject.org/rpms/dvb-apps/tree/master https://src.fedoraproject.org/rpms/dvb-apps/tree/f31
But retired packages are not branched any more. E.g. when thrift was retired, it didn't have the f31 branch yet. Once Fedora 31 branched the f31 braanch was not created in thrift.
You've requested unretirement on master and f31, but there is no f31 to unretire, hence you need to unretire on master and use fedpkg request-branch for f31.
fedpkg request-branch
Hope that makes sense.
@humaton When people request unretirement for an nonexisting branch, I suggest adding something like: "Unretired on master, use fedpkg request-branch for f31." Thanks
Got it. Thanks for the info.
Hmmm... all that command did was open another ticket at releng/fedora-scm-requests#15654 ; I wasn't expecting that. fedpkg request-branch appears to just be a tool to help people create well-structured tickets... but if we already had a ticket (this one), I don't see why running that command should be necessary if RELENG already understands the submitted request in an existing ticket like an unretire ticket. It kinda feels like I'm being told to serve a workflow, when the workflow should be serving us.
Yes, I agree with that statement 100%, yet this is how it is now.
Login to comment on this ticket.