#7900 New side tag for rawhide llvm 7.0 ABI change.
Closed: Fixed 5 years ago by mohanboddu. Opened 5 years ago by tstellar.

  • Describe the issue
    I need to break the ABI of libLLVM.so without a soname bump in order to fix an llvm bug[1]. I need a side-tag in order to rebuild all dependent packages without creating a disruption.

[1] https://bugs.llvm.org/show_bug.cgi?id=39427
When do you need this? (YYYY/MM/DD)
2018/11/01
When is this no longer needed or useful? (YYYY/MM/DD)
2019/08/01
* If we cannot complete your request, what is the impact?
Users will not be able to link programs compiled with clang against Fedora's llvm-libs package.


@tstellar Please use the side-tag template when requesting side tags. You can find the template when creating the ticket under "Types" just below the ticket title.

Anyway, can you answer:
* Name of the side tag?

  • Number of builds that are expected in the side tag?

  • How long do you need the side tag?

  • Any extra information?

Thanks.

@tstellar Please use the side-tag template when requesting side tags. You can find the template when creating the ticket under "Types" just below the ticket title.

OK, I will do that next time.

Anyway, can you answer:
* Name of the side tag?

llvm-7-abi-fix

Number of builds that are expected in the side tag?

9

How long do you need the side tag?

1 Month

Any extra information?

No.

Thanks.

@tstellar And what release you are planning it for?

I should have been more clearer with the "Name of the side tag" generally people ask something like f29-blah or f30-bleh side tag. Which helps me in identifying which release they are planning it for.

I will update the template and will be more clearer.

Sorry for the delay.

@tstellar f30-llvm tag has been created:

$ koji add-tag f30-llvm --parent=f30-build --arches='armv7hl i686 x86_64 aarch64 ppc64le s390x'
$ koji add-target f30-llvm f30-llvm

You can do builds with:

$ fedpkg build –target=f30-llvm

Let us know when you are done and we will move all the builds into f30.

Metadata Update from @mohanboddu:
- Issue tagged with: sidetarget

5 years ago

@tstellar Any update? We are branching tomorrow, so it would be great if we can merge them before then.

@sergesanspaille is working on this, there are still a few more packages to do.

If you guys need help to move this along faster, I'd be happy to create a llvm7 package for ABI compat.

@sergesanspaille is building the compat packages now. I think these are the last packages left to do.

@mohanboddu : there's one arch missing for clang7.0, then I'll rebuild pocl and we'll be able to merge. So we'll merge after the branching, is it safe if I do this tomorrow (20190220) ?

@sergesanspaille If we do it tomorrow, we can either merge them into either branched(F30) or rawhide(F31) but not both.

@sergesanspaille Sorry, my mistake, we can tag them both release mentioned above.

Thanks @ignatenkobrain @kevin for correcting me.

@mohanboddu I think rawhide will be enough, @tstellar correct me if I'm wrong.

@tstellar @sergesanspaille Would it be possible to merge this today? llvm 8 is supposed to land in F30 as well, not just rawhide/F31 that's 8 months away, right?

We have a GNOME test day on Monday and I'd like to make sure the desktop stack changes (mesa/llvm) are landed before the test day so that I have a chance to make sure things work together and make sure we have a test day image.

@kalev there's an issue with the pocl package I'd like to discuss about with @tstellar first.

All packages I wanted to add to f30-llvm now build correctly, two more should come in as soon as the associated PR are merged and this should be of for Monday.

@sergesanspaille Please let us know when its done and we will merge them into either F30 or F31 or both. Thanks.

@mohanboddu should be okay now, thanks a lot for your patience!

(merging for both f30 and f31 please)

⋊> ~/t/r/scripts on master ⨯ python3 ./mass-tag.py -s f30-llvm -t f31-pending                                                                         19:39:56
Checking 12 builds...
clang-8.0.0-0.2.rc2.fc30
Tagging clang-8.0.0-0.2.rc2.fc30 into f31-pending
clang7.0-7.0.1-9.fc30
Tagging clang7.0-7.0.1-9.fc30 into f31-pending
compiler-rt-8.0.0-0.2.rc2.fc30
Tagging compiler-rt-8.0.0-0.2.rc2.fc30 into f31-pending
libcxx-8.0.0-0.2.rc2.fc30
Tagging libcxx-8.0.0-0.2.rc2.fc30 into f31-pending
libcxxabi-8.0.0-0.2.rc2.fc30
Tagging libcxxabi-8.0.0-0.2.rc2.fc30 into f31-pending
libomp-8.0.0-0.2.rc2.fc30
Tagging libomp-8.0.0-0.2.rc2.fc30 into f31-pending
lld-8.0.0-0.2.rc2.fc30
Tagging lld-8.0.0-0.2.rc2.fc30 into f31-pending
lldb-8.0.0-0.2.rc2.fc30
Tagging lldb-8.0.0-0.2.rc2.fc30 into f31-pending
llvm-8.0.0-0.2.rc2.fc30
Tagging llvm-8.0.0-0.2.rc2.fc30 into f31-pending
llvm-test-suite-8.0.0-0.2.rc2.fc30
Tagging llvm-test-suite-8.0.0-0.2.rc2.fc30 into f31-pending
llvm7.0-7.0.1-3.fc30
Tagging llvm7.0-7.0.1-3.fc30 into f31-pending
pocl-1.2-1.20190221gita0b083a1b47a738.fc30
Tagging pocl-1.2-1.20190221gita0b083a1b47a738.fc30 into f31-pending
Tagging 12 builds.
Tagged 12 builds.
⋊> ~/t/r/scripts on master ⨯ python3 ./mass-tag.py -s f30-llvm -t f30-pending                                                                         19:40:15
Checking 12 builds...
clang-8.0.0-0.2.rc2.fc30
Tagging clang-8.0.0-0.2.rc2.fc30 into f30-pending
clang7.0-7.0.1-9.fc30
Tagging clang7.0-7.0.1-9.fc30 into f30-pending
compiler-rt-8.0.0-0.2.rc2.fc30
Tagging compiler-rt-8.0.0-0.2.rc2.fc30 into f30-pending
libcxx-8.0.0-0.2.rc2.fc30
Tagging libcxx-8.0.0-0.2.rc2.fc30 into f30-pending
libcxxabi-8.0.0-0.2.rc2.fc30
Tagging libcxxabi-8.0.0-0.2.rc2.fc30 into f30-pending
libomp-8.0.0-0.2.rc2.fc30
Tagging libomp-8.0.0-0.2.rc2.fc30 into f30-pending
lld-8.0.0-0.2.rc2.fc30
Tagging lld-8.0.0-0.2.rc2.fc30 into f30-pending
lldb-8.0.0-0.2.rc2.fc30
Tagging lldb-8.0.0-0.2.rc2.fc30 into f30-pending
llvm-8.0.0-0.2.rc2.fc30
Tagging llvm-8.0.0-0.2.rc2.fc30 into f30-pending
llvm-test-suite-8.0.0-0.2.rc2.fc30
Tagging llvm-test-suite-8.0.0-0.2.rc2.fc30 into f30-pending
llvm7.0-7.0.1-3.fc30
Tagging llvm7.0-7.0.1-3.fc30 into f30-pending
pocl-1.2-1.20190221gita0b083a1b47a738.fc30
Tagging pocl-1.2-1.20190221gita0b083a1b47a738.fc30 into f30-pending
Tagging 12 builds.
Tagged 12 builds.

Metadata Update from @mohanboddu:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

5 years ago

Login to comment on this ticket.

Metadata