#7604 F29 System-Wide Change: Remove Excessive Linking
Closed: Fixed 3 years ago by mohanboddu. Opened 3 years ago by ignatenkobrain.

Please review https://fedoraproject.org/wiki/Changes/RemoveExcessiveLinking change.

P.S. I don't think that any actions from rel-eng are needed.

A note from Change Wrangler: This Change proposal requires mass rebuild. The deadline for Change proposals requiring mass rebuild has passed two weeks ago (June 19th). I will leave the decision whether this can still be accepted to the F29 scope on RelEng team as I do not have clear visibility how much work this might bring.

@jkurik, ohh! There is nothing needed from releng, just if something fails entirely, second mass rebuild would be needed. But I don't expect that.

Metadata Update from @mohanboddu:
- Issue tagged with: changes, f29

3 years ago

@ignatenkobrain When is this change going to land?

@mohanboddu As soon as change is approved. Everything is ready for that.

@ignatenkobrain Then I am going to hold off on this whether we should include it in mass rebuild or not until the change request is processed.

Last I looked (less than a year ago), libtool still doesn't play well with -Wl,--as-needed and needs some sort of patch/hack to either libtool itself or %configure to overcome the reordering problem, I don't think it's fixed upstream (after all these years, sigh). See eg https://sigquit.wordpress.com/2011/02/16/why-asneeded-doesnt-work-as-expected-for-your-libraries-on-your-autotools-project/ and https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=347650.

Note that I'm certainly not objecting to this change, just pointing out that merely adding -Wl,--as-needed to LDFLAGS wont work for a significant number of packages.

@ignatenkobrain , what is the status of this request?

Metadata Update from @syeghiay:
- Issue untagged with: f29
- Issue assigned to mohanboddu
- Issue tagged with: f30, mass rebuild

3 years ago

This change has landed on redhat-rpm-config-116-1 and redhat-rpm-config-118-1 which were built on Jul 10th and Aug 15th of 2018.

Not including it in mass rebuild as its not needed anymore.

Metadata Update from @mohanboddu:
- Issue untagged with: mass rebuild
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)
- Issue tagged with: change-noreleng

3 years ago

Login to comment on this ticket.