#6421 [PATCH] update-fullfilelist unconditionally changes ctime of fullfilelist
Closed: Fixed None Opened 7 years ago by tibbs.

The update-fullfilelist script:

https://infrastructure.fedoraproject.org/cgit/ansible.git/tree/roles/bodhi2/backend/files/update-fullfilelist

unconditionally calls chmod on the two file lists. chmod unconditionally updates the inode ctime even when the permissions don't change. Normally nobody would care, but fullfiletimelist records the ctime change as part of its detection of hardlinking. This results in a change in fullfiletimelist, so quick-fedora-mirror clients will make an unnecessary connectiondo an unnecessary transfer of the file list.

I would suggest moving the chmod into the conditional. Alternately you could explicitly set umask to 022. Patch for the former attached..


Patch mocing chmod calls into conditionals
patch

I just realized that the source file uses tabs. I never use hard tabs and have my tab width set to four spaces so I didn't notice until I looked at the diff. Sorry about that.

Metadata Update from @tibbs:
- Issue set to the milestone: Fedora 24 Alpha

7 years ago

Login to comment on this ticket.

Metadata