#6413 It's Atomic Host, not Atomic
Closed: Fixed 5 years ago Opened 7 years ago by walters.

In the cases where we're talking about "Atomic Host", please rename the file name from just "Atomic" to "AtomicHost" (if the filename can't contain spaces).


I totally agree we need to be disciplined when talking about Atomic things vs. specifically talking about Atomic Host. However, I'm not sure it's necessary to rename images from Fedora-Cloud-Atomic to Fedora-Cloud-AtomicHost.

What's the technical need here? It's entirely possible I've missed that.

Because people constantly call it "the/an Atomic image", which is vague - there are multiple things named Atomic.

Metadata Update from @walters:
- Issue set to the milestone: Fedora 24 Alpha

7 years ago

Metadata Update from @ausil:
- Issue close_status updated to: None
- Issue set to the milestone: Fedora 26 Alpha (was: Fedora 24 Alpha)

7 years ago

Metadata Update from @ausil:
- Issue assigned to ausil

7 years ago

I don't mind changing the file name, but I'm a bit leery of changing the subvariant names. It will require anything that does comparisons across releases where we called it 'Atomic' and releases where we called it 'AtomicHost' to know that they're the same thing, for instance. Is it really necessary to change the subvariant names?

I guess we should discuss architecture in the issue here and keep comments in the PR for code review. Copying my comment then:

Thanks for taking a look at this! One of the conceptual issues down the line is - at some point, our concept of "compose" may need to include Docker/OCI images as well. If we did that, the compose as a whole might be Atomic, but the host image names should still IMO be AtomicHost. I'm not totally sure though - perhaps we'll just say the host and the "container management containers" are always asynchronous.

@adamwill What things compare across releases?

@walters the compose is still called Atomic. it is a rename of the cloud images and installer iso to AtomicHost. so we could add containers, or other things falling into a Atomic compose

@walters well, I have a script which runs through all Fedora releases from 1 onwards and stashes the size of each image in each release, so you can plot a graph of the sizes of the images throughout Fedora release history, for instance; if we change a subvariant name we'd have to handle that specially, or else it'd just appear as if some 'Atomic' images disappeared and some 'AtomicHost' images appeared in Fedora 26 (or 27, or whatever).

There's also stuff like - the openQA test scheduler uses the image subvariant as part of the formula for deciding what images to download and test. If the subvariant for the Atomic Host installer image changes in (say) 26+ but not 25, I'd have to somehow fudge that in the scheduler so that it looks for 'Atomic' subvariant for the Fedora 25 two-week Atomic nightly composes, but 'AtomicHost' subvariant for the Branched and Rawhide nightly composes...just stuff like that. There's various other things that use the subvariant, and there could be consequences for any of those, I can't remember all of them at this point and would either have to look through and find each one and evaluate it, or just make the change and fix any problems as we noticed them...it's just one of those things where the idea of changing it makes me leery.

@adamwill OK, I get that. I'd be happy to try to fix some of that myself if someone points me to the git repositories.

The benefit here is that the image name shows up in many places - e.g. if one is using it in OpenStack it can be very prominent, and I'd really like the name to be correct there.

I know that typing "Atomic Host" vs just "Atomic" (or "atomic" in chat) is harder - I personally tend to use "FAH" now for "Fedora Atomic Host", since it's both shorter and more descriptive assuming your audience knows the context.

@mohanboddu reports this work is done. Closed/Fixed.

Metadata Update from @syeghiay:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

5 years ago

Login to comment on this ticket.

Metadata