#12273 no longer possible to request an "eln" branch for packages
Closed: Fixed a month ago by kevin. Opened 3 months ago by decathorpe.

  • Describe the issue

Two of my packages are apparently going to be in ELN / CentOS Stream 10 / RHEL 10 (rust-sequoia-sq and rust-sequoia-sqv). Similar to other Rust packages, I want to maintain ELN packaging on a separate branch from rawhide, since Rust packaging in el-ish branches is vastly different from Fedora.

However, due to the decommisioning of PDC and Modularity, it seems I cannot request the "eln" branch in a self-service manner anymore:

$ fedpkg request-branch eln --sl rawhide:2099-12-01 
Could not execute request_branch: You can't provide SLs for release branches

So it looks like something in fedpkg has changed to no longer allow an SL for the "eln" branch. But omitting that argument leads to three faulty tickets being filed:

Unclear. I need this to build packages that are needed in CentOS Stream 10 in ELN.
I don't know how urgent this is.

  • When is this no longer needed or useful? (YYYY/MM/DD)

Unclear.

  • If we cannot complete your request, what is the impact?

Unclear. I don't know the process wrt/ how packages flow from ELN → CentOS Stream 10.


SLAs' are set for all stable fedora releases here: https://pagure.io/releng/blob/main/f/scripts/pdc/utilities.py#_29

We have not anything special for "eln" before not sure what is missing here, need to investigate.

The "eln" branch will probably need the same SLA as rawhide, since it's parallel to rawhide.

Sounds like we have two different bugs here:

1) The ELN branching procedure (which is infrequent) used to require passing the --sl argument as posted above. IIUC, fedpkg now checks with bodhi rather than PDC to determine release branches, so ELN is listed and it rejects the argument, but the tooling doesn't have an SLA defined and also fails without it. In theory https://pagure.io/releng/pull-request/12274 should fix that, but obviously I have no way to test it.

2) Modules should not be requested in this -- or at this point, any other -- case. That's probably a fedpkg bug.

Metadata Update from @phsmoura:
- Issue tagged with: investigation, medium-gain, medium-trouble, ops

3 months ago

I think the issue here is in https://pagure.io/fedora-infra/toddlers/blob/main/f/toddlers/plugins/scm_request_processor.py which needs to be adjusted to either don't check SLA for ELN or we need to add new SLAs to configuration for eln branches.

I prefer the second option.

I merged the PR and deployed the changes, could you try it now?

I did fedpkg request-branch eln --no-auto-module (to prevent fedpkg from filing requests for a module and a module branch), and that worked:

https://pagure.io/releng/fedora-scm-requests/issue/65456
https://pagure.io/releng/fedora-scm-requests/issue/65457

Now only fedpkg needs to be updated to recognize eln as a release branch instead of an arbitrarily-named module branch ...

Commit bc1d18e6 relates to this ticket

Hey @decathorpe, since the issue's fix commit has been merged now, are you still facing issues or is this fixed? If yes, can we close this?

I haven't needed to request an eln branch for a package since I opened this ticket, so I don't know what the current status is. However, looking at the changes to fedpkg and the fedora-scm-requests processing toddler, I think it should all be good now. Feel free to close this ticket for now. If I hit another problem with eln branches in the future, it will be because of a different issue anyway.

Metadata Update from @kevin:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

a month ago

Log in to comment on this ticket.

Metadata
Boards 1
Ops Status: Backlog