Issue #12023: Update pungi filters - releng

releng

#12023 Update pungi filters

Closed: Fixed 4 months ago by patrikp. Opened 2 years ago by kevin.

Our current filter for packages in pungi is:

filter_packages = [
    ("^.*$", {
        "*": ["glibc32", "libgcc32"],
        "s390x": ["rust-std-static-wasm*"],
    }),
    ('(Server)$', {
        '*': [
        'kernel*debug*',
        'kernel-kdump*',
        'kernel-tools*',
        'syslog-ng*',
        'astronomy-bookmarks',
        'generic*',
        'GConf2-dbus*',
        'bluez-gnome',
        'java-11-openjdk',
        'community-mysql*',
        'jruby*',
        'gimp-help-*',
        ]
    }),
]

There's a good reason for glibc32... but... the rest of that seems either out of date, or not sure why it's there.

We should ask server working group / rust sig about those and see if we can drop them in rawhide.
We should at least drop all the ones that no longer exist.

Metadata Update from @phsmoura:
- Issue tagged with: low-gain, low-trouble

2 years ago

jistone commented 2 years ago

"s390x": ["rust-std-static-wasm*"],

Those rust bits are noarch packages, but couldn't be installed on s390x because there was no lld to provide /usr/bin/wasm-ld -- but it's there as of LLVM 18! So we don't need that filter anymore on rawhide, nor f40 once the update lands.

fweimer commented 2 years ago

It turned out that libgcc32 was not needed after all because the required contents has always been shipped as part of gcc.x86_64. We never created that subpackage.

We still need to filter out glibc32, although the DNF5 compatibility cleanup allowed us to make its presence in a compose less harmful (the current glibc32 has much fewer Provides:).

Edited 2 years ago by fweimer

Metadata Update from @patrikp:
- Issue assigned to patrikp

10 months ago

patrikp commented 10 months ago

The config file lives here [1].

First step might be to check which packages still actually exist.

glibc32 is retired [2] so it can be removed.
libgcc32 was never created, a dist-git repo for it doesn't exist, so it can be removed.
openh264 was added by me and is there for good reasons, cannot be removed.
rust-std-static-wasm* can be removed as per one of the comments above.

That's everything for things not under Server.
Maybe we can summon someone from the Server Group SIG that might make us wiser?
And the PR should be opened only against the rawhide (main) branch, correct @kevin ?

[1] https://pagure.io/pungi-fedora/blob/main/f/fedora.conf.
[2] https://src.fedoraproject.org/rpms/glibc32/c/2eeeaa647f454f9e014d1a5accf1599d8c710795?branch=rawhide

fweimer commented 10 months ago

@patrikp The glibc32 package lives on as a subpackage of the glibc package. I think it should still be filled. We currently do not need libgcc32. There was a close call recently, but we worked around it without introducing it. I suppose if we ever need it, we can request a filter once we add it.

kevin commented 10 months ago

So... on the server ones:

This was setup 10 years ago when pungi was first setup. Probibly copied from mash.
Some of those packages no longer exist
None of those packages should be pulled into server composes.

I think personally that we can just drop them all.

So, we could:

Just drop them all and then carefully check the server images from rawhide after we do to make sure none of them somehow got back in
Test locally? This could be anoying to setup, but we could...

fweimer commented 10 months ago

@kevin @patrikp Has some of this been merged?

We are shipping glibc32-2.41-3.fc42.x86_64, glibc32-2.40-24.fc41.x86_64, glibc32-2.39-37.fc40.x86_64, which isn't ideal and likely to cause some problems.

kevin commented 10 months ago

We have made no changes so far... the updates pungi config has [] in filter list... as it has since 2017. :)

We are filtering it for rawhide/branched tho. (as noted in the config at the start of this ticket).

Note that if those things are in the base / GA repo, we don't change that after release, so they will be there... if they are in updates we can filter them out.

fweimer commented 10 months ago

Looks like it's updates only:

#  dnf info --disablerepo='*updates*' glibc32
Updating and loading repositories:
 Fedora 41 openh264 (From Cisco) - x86_ 100% |   4.1 KiB/s |   4.8 KiB |  00m01s
 Fedora 41 - x86_64                     100% |  10.8 MiB/s |  35.3 MiB |  00m03s
Repositories loaded.
No matching packages to list

# dnf info --disablerepo='*updates*' glibc32
Updating and loading repositories:
 Fedora 42 openh264 (From Cisco) - x86_ 100% |   3.3 KiB/s |   4.8 KiB |  00m01s
 Fedora 42 - x86_64                     100% |   7.7 MiB/s |  35.4 MiB |  00m05s
Repositories loaded.

jnsamyak commented 5 months ago

cc: @patrikp^

Metadata Update from @patrikp:
- Issue tagged with: sprint-2

4 months ago

patrikp commented 4 months ago

Here's a small status update. There actually was a PR opened a while ago [1] that I forgot to link here, it sat there for a few months and got merged a couple of days ago. We seem to have gotten a rawhide compose just fine with these changes.

The question is, what else is necessary? We will probably have to make some more changes in Bodhi and in Ansible but I'm unsure where exactly. And final freeze begins today which likely means no Ansible changes.

@kevin Your insights and advice would be most welcome. Thank you.

[1] https://pagure.io/pungi-fedora/pull-request/1488

kevin commented 4 months ago

Yes, we need to add 'glibc32' to https://pagure.io/fedora-infra/ansible/blob/main/f/roles/bodhi2/backend/templates/pungi.rpm.conf.j2#_139

patrikp commented 4 months ago

If that's all that's required then here's the PR:
https://pagure.io/fedora-infra/ansible/pull-request/2894

I'm not sure if we want to merge it now since we're in final freeze, though.

patrikp commented 4 months ago

All the PRs are merged now so I'm closing the ticket.

Issue status updated to: Closed (was: Open)
Issue close_status updated to: Fixed

4 months ago