The way bodhi detects the content type of flatpaks no longer works with f39+/new flatpak composing.
This results in bodhi thinking the flatpak updates are rpms, and when it tried to get rpm header info it fails.
We will need to adjust bodhi or flatpak koji plugin to handle this before we push any f39 flatpak updates.
I unpushed the existing ones so we can get all other updates flowing.
CC: @yselkowitz @otaylor @kalev
Hmm, ah - https://github.com/fedora-infra/bodhi/blob/develop/bodhi-server/bodhi/server/models.py#L593
elif 'container_koji_task_id' in extra: if 'flatpak' in extra['image']: identity = cls.flatpak else: identity = cls.container
I'm not sure why container_koji_task_id was even added by koji-containerbuild - Koji has that back reference already for any build. I could add it in koji-flatpak, but I think I'd prefer to improve the Bodhi logic. Something like:
container_koji_task_id
elif 'image' in extra.get('typeinfo', {}): image_extra = extra['typeinfo']['image] if image_extra.get('index', {}).get('pull') is None: raise BodhiException("Can't create update for image, no pull spec") if 'flatpak' in image_extra: identity = cls.flatpak else: identity = cls.container
If patching Bodhi seems fine, I'll create a PR on Monday.
Yeah, fixing bodhi seems fine.
Metadata Update from @phsmoura: - Issue tagged with: high-gain, medium-trouble
This is all done now I think.
Metadata Update from @kevin: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
Log in to comment on this ticket.