#11089 Please, rename Fedora-Server-KVM Checksum file for F37 to be different from ISO
Closed: Fixed with Explanation 6 months ago by amedvede. Opened 2 years ago by pboy.

Currently, the checksum file for Fedora Server KVM and Fedora Server ISO files have the same name. When a user downloads the iso and the KVM files in one go (likely, because they want to use both) the latter download silently overwrite the former. And when the user verifies the download, error messages are the result.

  • When do you need this? (YYYY/MM/DD) immediately for F37

  • If we cannot complete your request, what is the impact?
    We produce unnecessary and confusing error messages, and there is no indication for the user about the reason.


A proper name might be:
Fedora-Server-img-37-x86_64.CHECKSUM
Fedora-Server-img-37-aarch64.CHECKSUM

Hi, this is a default name convention for each disc image. It is defined globally for the whole compose here: https://pagure.io/pungi-fedora/blob/main/f/fedora.conf#_90

I am not sure how to change it for just one image, so adding subvariants to the filename is an option but it will change for all images and have a big impact.

Metadata Update from @humaton:
- Issue tagged with: medium-gain, medium-trouble, ops

2 years ago

Thanks for the info. So that is nothing to a week before release date. But probably it is a good idea to harmonize the naming convention in the future. Specifically the order of the elements, somethink like
- "product" (Fedora server, Fedora Workstation, etc)
- Release. (38, 39, ...
- (branch) (20230110, 202301 15, ...)
- arch (aarch64, x86_64, ...)
- Subtype (DVD netinst, VM, ...)
- Filetye (iso, raw, checksum)

so that files that belong together are listed together in the file listing and do not have the same names for different things.

Of course, this is more fine-tuning than is urgently needed. But it would be nice, and makes a mature product.

Metadata Update from @amedvede:
- Issue assigned to amedvede

a year ago

HI,

so we have a PR that address this change.
Before merging it I would like to have ack from @adamwill, I have a feeling this will break some tests that are checking the checksums.

I don't think we actually have automated the checksum tests, weirdly enough, so that shouldn't be an issue.

The PR is merged, next rawhide compose should have the change.

PR is merged, @pboy hopefully, that is what you wanted. https://dl.fedoraproject.org/pub/fedora/linux/development/rawhide/Server/x86_64/images/
https://dl.fedoraproject.org/pub/fedora/linux/development/rawhide/Server/x86_64/iso/
for example, checksum files have different names now for those files. Can you approve that it is what you require if so, I can close this ticket)

@pboy hi, is the previous comment relevant?

It fixed and it's already working in Fedora 40+. I added {dirname} placeholder to the media_checksum_base_filename and no it generated proper names for each folder.
https://dl.fedoraproject.org/pub/fedora/linux/development/rawhide/Server/x86_64/images/
https://dl.fedoraproject.org/pub/fedora/linux/development/rawhide/Server/x86_64/iso/
for example, checksum files have different names now for those files.

Metadata Update from @amedvede:
- Issue close_status updated to: Fixed with Explanation
- Issue status updated to: Closed (was: Open)

6 months ago

Login to comment on this ticket.

Metadata
Boards 1
Ops Status: Backlog