#11054 Please remove the escape char in python-pyABF's git history: makes createrepo_c fail
Closed: It's all good 2 years ago by ankursinha. Opened 2 years ago by ankursinha.

  • Describe the issue
    It appears an escape char in the python-pyABF git history makes createrepo_c to barf. So, I think we need to remove it, which requires (another) fix and rebase.
    https://bodhi.fedoraproject.org/updates/FEDORA-2022-1a13497ca7#comment-2731513

  • When do you need this? (YYYY/MM/DD)
    Whenever convenient please

  • When is this no longer needed or useful? (YYYY/MM/DD)
    NA

  • If we cannot complete your request, what is the impact?
    Package updates cannot be pushed

Trying to run createrepo_c locally to debug this says:

createrepo_c . -v
09:37:07: Version: 0.20.1 (Features: DeltaRPM LegacyWeakdeps )
09:37:07: Signal handler setup
09:37:07: Thread pool ready
Directory walk started
09:37:07: Adding pkg: ./python3-pyABF-2.3.6-2.fc36.noarch.rpm
09:37:07: Dir to scan: ./repodata
09:37:07: Adding pkg: ./python-pyABF-2.3.6-2.fc36.src.rpm
09:37:07: Dir to scan: ./.repodata
09:37:07: Package count: 2
Directory walk done - 2 packages
Temporary output repo path: ./.repodata/
09:37:07: Creating .xml.gz files
09:37:07: Setting number of packages
Preparing sqlite DBs
09:37:07: Creating databases
09:37:07: Thread pool user data ready
Pool started (with 5 workers)
C_CREATEREPOLIB: Critical: Cannot dump XML for python3-pyABF (a35273bcb989b8eb6b7cd8f5bbae8443955a3ad299bc026db2ed9e27204245d3): Forbidden control chars found (ASCII values <32 except 9, 10 and 13).
C_CREATEREPOLIB: Critical: Cannot dump XML for python-pyABF (65791454f6fb9b09addc64ad9902ffec693caa9394762260aa61cf95cca47537): Forbidden control chars found (ASCII values <32 except 9, 10 and 13).
Pool finished with errors
Warning: There were some invalid packages: we have to recompress other, filelists and primary xml metadata files in order to have correct package counts
09:37:08: Generating repomd.xml
09:37:08: Copying files from old repository to the new one
09:37:08: Retention type: 0 (0)
09:37:08: Excluded: repomd.xml
09:37:08: Excluded: 95a4415d859d7120efb6b3cf964c07bebbff9a5275ca673e6e74a97bcbfb2a5f-filelists.xml.gz
09:37:08: Excluded: 6f4519292d66c22181286fb7cab06f8f46193372b0d6eafbea53133433ad12b5-primary.sqlite.bz2
09:37:08: Excluded: 1cb61ea996355add02b1426ed4c1780ea75ce0c04c5d1107c025c3fbd7d8bcae-primary.xml.gz
09:37:08: Excluded: f932c9857a756b95d690732c0c3017fead3cb0d355c1caf793a53dd92334043c-filelists.sqlite.bz2
09:37:08: Excluded: ef3e20691954c3d1318ec3071a982da339f4ed76967ded668b795c9e070aaab6-other.xml.gz
09:37:08: Excluded: 394ca1ed838088e625b9def36abc69e8c190739ef64f44d4d0bd549a56306f8a-other.sqlite.bz2
09:37:08: Renamed ./repodata/ -> ./repodata.old.3258426.20220928093708.425270
09:37:08: Renamed ./.repodata/ -> ./repodata/
09:37:08: Old repo ./repodata.old.3258426.20220928093708.425270 removed
09:37:08: Memory cleanup
09:37:08: All done

It looks like the non-printable character is in commit 527efcd, so could someone please edit that git message to remove it:

pick 527efcd added patch ^[[200~9cd568066b5ff8d6079e2d8cf8af388066cc9b79~

CC: @kevin


(needs to be done on rawhide and f36, luckily we haven't updated f37 yet).

CC: @vanessakris : just so you are also aware that we need to make sure our git messages don't contain non-printable characters, (I didn't know this either!)

This should work around it without having to change git: https://src.fedoraproject.org/rpms/python-pyABF/pull-request/1

can we just do that?

Yup, merged that and building now. Thanks.

Metadata Update from @ankursinha:
- Issue close_status updated to: It's all good
- Issue status updated to: Closed (was: Open)

2 years ago

Login to comment on this ticket.

Metadata