#2 Add some files
Merged by mohanboddu. Opened by humaton.
releng/ humaton/fmc add_files  into  master

Download 2.patch
no initial comment

1 new commit added

  • Add Readme

1 new commit added

  • Add consumer object skeleton

5 new commits added

  • Add consumer object skeleton
  • Add Readme
  • Add requirements.txt and Dockerfile
  • Add .gitignore
  • PEP8 compatible formatting

5 new commits added

  • Add consumer object skeleton
  • Add Readme
  • Add requirements.txt and Dockerfile
  • Add .gitignore
  • PEP8 compatible formatting

5 new commits added

  • Add consumer object skeleton
  • Add Readme
  • Add requirements.txt and Dockerfile
  • Add .gitignore
  • PEP8 compatible formatting

If you want to follow pep8, then this import should be before the fedora_messaging ones. (https://www.python.org/dev/peps/pep-0008/#imports)

You could capitalize to make it obvious that this is a global variable

There is already a README.md in the repo, so this should probably be added to it or we should delete the old README.md file.

we could probably use a Fedora 31 base image instead of F30 :)

a few minor comments but otherwise looks good :thumbsup:

1 new commit added

  • More work

rebased onto d61c397165819e6b11ef82f05a57a78d832135c4

Pull-Request has been merged by mohanboddu

Metadata