5b908f4
@@ -1,9 +1,9 @@
document: modulemd-defaults
version: 1
data:
- modified: 201906261200
+ modified: 202202011400
module: nodejs
profiles:
- 8: [default]
- 10: [default]
- 12: [default]
+ 12: [common]
+ 14: [common]
+ 16: [common]
Streams 8 and 10 have reached EOL and the newer streams are using "common" as the default profile.
Signed-off-by: Stephen Gallagher sgallagh@redhat.com
Are you sure?
# dnf module list nodejs Last metadata expiration check: 2:18:44 ago on Tue 01 Feb 2022 01:06:10 PM CET. Fedora - Modular Rawhide - Developmental packages for the next Fedora release Name Stream Profiles Summary nodejs 14 default, development, minimal Javascript runtime nodejs 16 default, development, minimal Javascript runtime
I cannot see any "common" profile. Checking the latest nodejs:16 build in Koji https://koji.fedoraproject.org/koji/buildinfo?buildID=1876824 also does not show any "common" profile.
Metadata Update from @ppisar: - Request assigned
The builds with the changed profile name are in progress. See https://src.fedoraproject.org/modules/nodejs/blob/16/f/nodejs.yaml#_24
I see. The builds are failing. Nevertheless I will merge this change because current F36 contains only streams 14, and 16 and none of them have set a default profile.
Pull-Request has been closed by ppisar
Do you want me to apply this change also the stable Fedoras? I can see you have pushed some of the builds into testing. But that builds remove "default" profile (nodejs:14 in F35; nodejs:12, nodejs:14 in F36). Do you indeed want to make this incompatible change there?
Yes, that is intentional. Please backport the same change for the defaults.
On Mon, Feb 7, 2022 at 8:00 AM Petr Pisar pagure@pagure.io wrote:
ppisar commented on the pull-request: Update Node.js profile defaults that you are following: Do you want me to apply this change also the stable Fedoras? I can see you have pushed some of the builds into testing. But that builds remove "default" profile (nodejs:14 in F35; nodejs:12, nodejs:14 in F36). Do you indeed want to make this incompatible change there? To reply, visit the link below or just reply to this email https://pagure.io/releng/fedora-module-defaults/pull-request/233
ppisar commented on the pull-request: Update Node.js profile defaults that you are following: Do you want me to apply this change also the stable Fedoras? I can see you have pushed some of the builds into testing. But that builds remove "default" profile (nodejs:14 in F35; nodejs:12, nodejs:14 in F36). Do you indeed want to make this incompatible change there?
Update Node.js profile defaults
To reply, visit the link below or just reply to this email https://pagure.io/releng/fedora-module-defaults/pull-request/233
Done.
sgallagh
commented 3 years ago
Streams 8 and 10 have reached EOL and the newer streams are using
"common" as the default profile.
Signed-off-by: Stephen Gallagher sgallagh@redhat.com