ccb5522
@@ -0,0 +1,12 @@
+ ---
+ document: modulemd-obsoletes
+ version: 1
+ data:
+ modified: 2022-01-24T08:54Z
+ module: perl
+ stream: "5.30"
+ eol_date: 2021-06-01T00:00Z
+ message: "Module stream perl:5.30 is no longer supported. Please switch to perl:5.32"
+ obsoleted_by:
+ stream: "5.32"
Signed-off-by: Filip Valder fvalder@redhat.com
@ppisar Please for review & thanks in advance. /cc @jplesnik
Please wait, I found some issue with the validation of obsoletes <name>-<stream>.yaml which I need to fix first, as this is to be different from the defaults validation.
Metadata Update from @ppisar: - Request assigned
This bug?
Obsoletes (tests): ================== nodejs:11 ERROR:root:Module name "perl" doesn't match filename "perl-5.30.yaml" Traceback (most recent call last): File "/home/petr/fedora-modules/fedora-module-defaults/./tests/validate.py", line 252, in <module> sys.exit(main()) File "/home/petr/fedora-modules/fedora-module-defaults/./tests/validate.py", line 234, in main idx_runtime.add_obsoletes(mmd) TypeError: Argument 1 does not allow None as a value
If you are going to keep checking for a file name and keep the stream in the file name, then use a colon as a separator (perl:5.30.yaml) rather than a hyphen. Hyphen is a valid character of a module and a stream, hence a-b-c.yaml based on a-b:c would clash with a file name based on a:b-c.
#230 should fix the issue. Please for checking it first, then we can continue this one...
You can continue with rebasing this commit.
rebased onto dcdade7b8f28d99c36a0880093443b57e0939500
Should be ready for final...
rebased onto ccb5522
Pull-Request has been merged by ppisar
Merged into main branch for Fedora 36.
Did you know that Fedora 36 does not contain perl:5.30? I think we also should apply these changes to Fedora 35 which is the last Fedora with perl:5.30. And also to Fedora 34 which also contains perl:5.30.
Should I wait with backporting these changes until having a Fedora 36 compose and verifying it does not break anything? Please note that Fedora 36 undergoes a mass rebuild right now and that a compose process may be delayed or broken for few days or weeks for other reasons than this obsoletes change.
Signed-off-by: Filip Valder fvalder@redhat.com