#16 Fix an install bug
Merged 3 months ago by pingou. Opened 2 years ago by qulogic.
qulogic/r2spec install-bugs  into  master

file removed
-11

@@ -1,11 +0,0 @@ 

- Metadata-Version: 1.1

- Name: R2spec

- Version: 4.2.1

- Summary: R2spec is a small python tool that generates spec file and rpm for R libraries.

- Home-page: https://fedorahosted.org/r2spec/

- Author: Pierre-Yves Chibon

- Author-email: pingou@pingoured.fr

- License: GPLv3+

- Download-URL: https://fedorahosted.org/releases/r/2/r2spec/

- Description: UNKNOWN

- Platform: UNKNOWN

file modified
+2 -1

@@ -5,7 +5,7 @@ 

  

  from __future__ import absolute_import, division, print_function

  

- from distutils.core import setup

+ from setuptools import setup

  from r2spec import VERSION

  

  setup(

@@ -24,5 +24,6 @@ 

      url='https://pagure.io/r2spec',

      package_dir = {'R2spec': 'r2spec'},

      packages = ['r2spec'],

+     include_package_data=True,

      scripts=['R2spec', 'R2rpm'],

      )

The specfile.tpl does not get installed without include_package_data=True.

rebased onto 9eca97d

4 months ago

rebased onto 9dbe5c5

4 months ago

I've tried this patch and did: python3 setup.py install --root=tmp and this is the tree I get:

tmp
├── etc
│   └── R2spec
│       └── repos.cfg
└── usr
    ├── local
    │   ├── bin
    │   │   ├── R2rpm
    │   │   └── R2spec
    │   └── lib
    │       └── python3.7
    │           └── site-packages
    │               ├── r2spec
    │               │   ├── build.py
    │               │   ├── __init__.py
    │               │   ├── __pycache__
    │               │   │   ├── build.cpython-37.pyc
    │               │   │   ├── __init__.cpython-37.pyc
    │               │   │   ├── r2spec_obj.cpython-37.pyc
    │               │   │   ├── rpackage.cpython-37.pyc
    │               │   │   └── spec.cpython-37.pyc
    │               │   ├── r2spec_obj.py
    │               │   ├── rpackage.py
    │               │   └── spec.py
    │               └── R2spec-4.2.1-py3.7.egg-info
    └── share
        └── man
            └── man1
                ├── R2rpm.1
                └── R2spec.1

As you can see the template file still doesn't get installed automatically :(

It works with pip, probably because it forces setuptools.

Alright, with setuptools it works :)

Let's rebase and get this in :)

rebased onto 48eea90

3 months ago

Pull-Request has been merged by pingou

3 months ago
Metadata