PR#658: ostree: Don't automatically create a repo - pungi

pungi

#658 ostree: Don't automatically create a repo

Merged 6 years ago by ausil. Opened 6 years ago by walters.

walters/pungi ostree-dont-init-repo into master

ostree: Don't automatically create a repo

Colin Walters • 6 years ago

af631f5

pungi/ostree/tree.py

file modified

-9

		`@@ -25,14 +25,6 @@`


		`class Tree(OSTree):`
		`- def _init_repo(self):`
		`- """If the ostree repo does not exist, initialize it."""`
		`- log_file = make_log_file(self.logdir, 'init-ostree-repo')`
		`- if not os.path.isdir(self.repo) or not os.listdir(self.repo):`
		`- makedirs(self.repo)`
		`- shortcuts.run(['ostree', 'init', '--repo=%s' % self.repo, '--mode=archive-z2'],`
		`- show_cmd=True, stdout=True, logfile=log_file)`
		`-`
		`def _make_tree(self):`
		`"""Compose OSTree tree"""`
		`log_file = make_log_file(self.logdir, 'create-ostree-repo')`
		`@@ -95,7 +87,6 @@`

		`self.commitid_file = make_log_file(self.logdir, 'commitid')`

		`- self._init_repo()`
		`self._make_tree()`
		`self._update_ref()`
		`if self.update_summary:`

walters commented 6 years ago

Creating an OSTree repository is a notable event; the general
expectation is that rather than having lots of repositories,
one has branches inside a single repository.

For $reasons, Fedora is not currently doing this, but we will
change it to do so.

The reason I'm making this change is we discovered that
it looked like Fedora had somehow made a repo inside a repo,
presumably due to a configuration error.

https://lists.fedoraproject.org/archives/list/cloud@lists.fedoraproject.org/message/GBFSOLULGGZFGEFCIW6FG23NZZV5VH4K/